Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index 0c577b651df47ac9e6df319f0b71e1cd4f610cc1..d29202ffbb9f4505ce154d924f4c6052a5a1ea68 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -652,9 +652,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, EvaluateInBlankPage) {
std::unique_ptr<base::DictionaryValue> params(new base::DictionaryValue());
params->SetString("expression", "window");
SendCommand("Runtime.evaluate", std::move(params), true);
- bool wasThrown = true;
- EXPECT_TRUE(result_->GetBoolean("wasThrown", &wasThrown));
- EXPECT_FALSE(wasThrown);
+ EXPECT_FALSE(result_->HasKey("exceptionDetails"));
}
IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest,
@@ -667,9 +665,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest,
std::unique_ptr<base::DictionaryValue> params(new base::DictionaryValue());
params->SetString("expression", "window");
SendCommand("Runtime.evaluate", std::move(params), true);
- bool wasThrown = true;
- EXPECT_TRUE(result_->GetBoolean("wasThrown", &wasThrown));
- EXPECT_FALSE(wasThrown);
+ EXPECT_FALSE(result_->HasKey("exceptionDetails"));
}
IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, JavaScriptDialogNotifications) {
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698