Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 v8::MaybeLocal<v8::Value> resolveCallArgument(ErrorString*, protocol::Runtim e::CallArgument*); 78 v8::MaybeLocal<v8::Value> resolveCallArgument(ErrorString*, protocol::Runtim e::CallArgument*);
79 79
80 std::unique_ptr<protocol::Runtime::ExceptionDetails> createExceptionDetails( v8::Local<v8::Message>); 80 std::unique_ptr<protocol::Runtime::ExceptionDetails> createExceptionDetails( v8::Local<v8::Message>);
81 void wrapEvaluateResult(ErrorString*, 81 void wrapEvaluateResult(ErrorString*,
82 v8::MaybeLocal<v8::Value> maybeResultValue, 82 v8::MaybeLocal<v8::Value> maybeResultValue,
83 const v8::TryCatch&, 83 const v8::TryCatch&,
84 const String16& objectGroup, 84 const String16& objectGroup,
85 bool returnByValue, 85 bool returnByValue,
86 bool generatePreview, 86 bool generatePreview,
87 std::unique_ptr<protocol::Runtime::RemoteObject>* result, 87 std::unique_ptr<protocol::Runtime::RemoteObject>* result,
88 Maybe<bool>* wasThrown,
89 Maybe<protocol::Runtime::ExceptionDetails>*); 88 Maybe<protocol::Runtime::ExceptionDetails>*);
90 v8::Local<v8::Value> lastEvaluationResult() const; 89 v8::Local<v8::Value> lastEvaluationResult() const;
91 90
92 class Scope { 91 class Scope {
93 public: 92 public:
94 bool initialize(); 93 bool initialize();
95 bool installCommandLineAPI(); 94 bool installCommandLineAPI();
96 void ignoreExceptionsAndMuteConsole(); 95 void ignoreExceptionsAndMuteConsole();
97 void pretendUserGesture(); 96 void pretendUserGesture();
98 v8::Local<v8::Context> context() const { return m_context; } 97 v8::Local<v8::Context> context() const { return m_context; }
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 InspectedContext* m_context; 166 InspectedContext* m_context;
168 v8::Global<v8::Value> m_value; 167 v8::Global<v8::Value> m_value;
169 v8::Global<v8::Value> m_lastEvaluationResult; 168 v8::Global<v8::Value> m_lastEvaluationResult;
170 std::unique_ptr<InjectedScriptNative> m_native; 169 std::unique_ptr<InjectedScriptNative> m_native;
171 v8::Global<v8::Object> m_commandLineAPI; 170 v8::Global<v8::Object> m_commandLineAPI;
172 }; 171 };
173 172
174 } // namespace blink 173 } // namespace blink
175 174
176 #endif 175 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698