Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8DebuggerAgentImpl_h 5 #ifndef V8DebuggerAgentImpl_h
6 #define V8DebuggerAgentImpl_h 6 #define V8DebuggerAgentImpl_h
7 7
8 #include "platform/inspector_protocol/Collections.h" 8 #include "platform/inspector_protocol/Collections.h"
9 #include "platform/inspector_protocol/String16.h" 9 #include "platform/inspector_protocol/String16.h"
10 #include "platform/v8_inspector/JavaScriptCallFrame.h" 10 #include "platform/v8_inspector/JavaScriptCallFrame.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 void setPauseOnExceptions(ErrorString*, const String16& pauseState) override ; 99 void setPauseOnExceptions(ErrorString*, const String16& pauseState) override ;
100 void evaluateOnCallFrame(ErrorString*, 100 void evaluateOnCallFrame(ErrorString*,
101 const String16& callFrameId, 101 const String16& callFrameId,
102 const String16& expression, 102 const String16& expression,
103 const Maybe<String16>& objectGroup, 103 const Maybe<String16>& objectGroup,
104 const Maybe<bool>& includeCommandLineAPI, 104 const Maybe<bool>& includeCommandLineAPI,
105 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole, 105 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole,
106 const Maybe<bool>& returnByValue, 106 const Maybe<bool>& returnByValue,
107 const Maybe<bool>& generatePreview, 107 const Maybe<bool>& generatePreview,
108 std::unique_ptr<protocol::Runtime::RemoteObject>* result, 108 std::unique_ptr<protocol::Runtime::RemoteObject>* result,
109 Maybe<bool>* wasThrown,
110 Maybe<protocol::Runtime::ExceptionDetails>*) override; 109 Maybe<protocol::Runtime::ExceptionDetails>*) override;
111 void setVariableValue(ErrorString*, 110 void setVariableValue(ErrorString*,
112 int scopeNumber, 111 int scopeNumber,
113 const String16& variableName, 112 const String16& variableName,
114 std::unique_ptr<protocol::Runtime::CallArgument> newValue, 113 std::unique_ptr<protocol::Runtime::CallArgument> newValue,
115 const String16& callFrame) override; 114 const String16& callFrame) override;
116 void setAsyncCallStackDepth(ErrorString*, int depth) override; 115 void setAsyncCallStackDepth(ErrorString*, int depth) override;
117 void setBlackboxPatterns(ErrorString*, 116 void setBlackboxPatterns(ErrorString*,
118 std::unique_ptr<protocol::Array<String16>> patterns) override; 117 std::unique_ptr<protocol::Array<String16>> patterns) override;
119 void setBlackboxedRanges(ErrorString*, 118 void setBlackboxedRanges(ErrorString*,
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 bool m_skipAllPauses; 208 bool m_skipAllPauses;
210 209
211 std::unique_ptr<V8Regex> m_blackboxPattern; 210 std::unique_ptr<V8Regex> m_blackboxPattern;
212 protocol::HashMap<String16, std::vector<std::pair<int, int>>> m_blackboxedPo sitions; 211 protocol::HashMap<String16, std::vector<std::pair<int, int>>> m_blackboxedPo sitions;
213 }; 212 };
214 213
215 } // namespace blink 214 } // namespace blink
216 215
217 216
218 #endif // V8DebuggerAgentImpl_h 217 #endif // V8DebuggerAgentImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698