third_party/WebKit/LayoutTests/http/tests/inspector-protocol/access-inspected-object.html - Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/inspector-protocol/access-inspected-object.html

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-restart.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script type="text/javascript" src="inspector-protocol-test.js"></script>	3 <script type="text/javascript" src="inspector-protocol-test.js"></script>

4 <script>	4 <script>

5 if (window.testRunner) {	5 if (window.testRunner) {

6 testRunner.dumpAsText();	6 testRunner.dumpAsText();

7 testRunner.waitUntilDone();	7 testRunner.waitUntilDone();

8 }	8 }

9	9

10 function test()	10 function test()

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
50 function didAddInspectedNode(messageObject)	50 function didAddInspectedNode(messageObject)

51 {	51 {

52 InspectorTest.sendCommand("Runtime.evaluate", {	52 InspectorTest.sendCommand("Runtime.evaluate", {

53 "expression": "$0",	53 "expression": "$0",

54 "includeCommandLineAPI": true	54 "includeCommandLineAPI": true

55 }, didEvaluate);	55 }, didEvaluate);

56 }	56 }

57	57

58 function didEvaluate(messageObject)	58 function didEvaluate(messageObject)

59 {	59 {

60 if (messageObject.result.wasThrown)	60 if (!!messageObject.result.exceptionDetails)

61 InspectorTest.log("FAIL: unexpected exception: " + JSON.stringify(me ssageObject, null, 2));	61 InspectorTest.log("FAIL: unexpected exception: " + JSON.stringify(me ssageObject, null, 2));

62 if (messageObject.result.result.value !== null)	62 if (messageObject.result.result.value !== null)

63 InspectorTest.log("FAIL: unexpected value: " + JSON.stringify(messag eObject, null, 2));	63 InspectorTest.log("FAIL: unexpected value: " + JSON.stringify(messag eObject, null, 2));

64 InspectorTest.completeTest();	64 InspectorTest.completeTest();

65 }	65 }

66 }	66 }

67	67

68 </script>	68 </script>

69 </head>	69 </head>

70 <body>	70 <body>

71 <p>Test that code evaluated in the main frame cannot access $0 that resolves int o a node in a frame from a different domain. <a href="https://bugs.webkit.org/sh ow_bug.cgi?id=105423">Bug 105423.</p>	71 <p>Test that code evaluated in the main frame cannot access $0 that resolves int o a node in a frame from a different domain. <a href="https://bugs.webkit.org/sh ow_bug.cgi?id=105423">Bug 105423.</p>

72 <iframe id="myframe" src="http://localhost:8000/inspector-protocol/resources/tes t-page.html" onload="runTest()"></iframe>	72 <iframe id="myframe" src="http://localhost:8000/inspector-protocol/resources/tes t-page.html" onload="runTest()"></iframe>

73 </body>	73 </body>

74 </html>	74 </html>

OLD	NEW