Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
index 83e423c50a592987e32ef18ea84a900b1282799c..b5d42b7fc9e85b68bb512d5d0ec7d1a32c2baf35 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
@@ -256,11 +256,10 @@ WebInspector.RuntimeModel.prototype = {
/**
* @param {?Protocol.Error} error
- * @param {?RuntimeAgent.RemoteObject} result
- * @param {boolean=} wasThrown
- * @param {?RuntimeAgent.ExceptionDetails=} exceptionDetails
+ * @param {!RuntimeAgent.RemoteObject} result
+ * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
*/
- function innerCallback(error, result, wasThrown, exceptionDetails)
+ function innerCallback(error, result, exceptionDetails)
{
if (error) {
console.error(error);
@@ -596,10 +595,9 @@ WebInspector.ExecutionContext.prototype = {
* @this {WebInspector.ExecutionContext}
* @param {?Protocol.Error} error
* @param {!RuntimeAgent.RemoteObject} result
- * @param {boolean=} wasThrown
- * @param {?RuntimeAgent.ExceptionDetails=} exceptionDetails
+ * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
*/
- function evalCallback(error, result, wasThrown, exceptionDetails)
+ function evalCallback(error, result, exceptionDetails)
{
if (error) {
console.error(error);
@@ -607,6 +605,7 @@ WebInspector.ExecutionContext.prototype = {
return;
}
+ var wasThrown = !!exceptionDetails;
if (returnByValue)
callback(null, !!wasThrown, wasThrown ? null : result, exceptionDetails);
else

Powered by Google App Engine
This is Rietveld 408576698