Chromium Code Reviews Chromium Code Reviews
Issue 2234983002:
[DevTools] Removed wasThrown from evaluate-like protocol methods (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <html> | 1 <html> |
| 2 <head> | 2 <head> |
| 3 <script src="../../http/tests/inspector/inspector-test.js"></script> | 3 <script src="../../http/tests/inspector/inspector-test.js"></script> |
| 4 <script> | 4 <script> |
| 5 | 5 |
| 6 var object1 = { get foo() { return 1; }, set foo(value) { } }; | 6 var object1 = { get foo() { return 1; }, set foo(value) { } }; |
| 7 var object2 = { get foo() { return 1; } }; | 7 var object2 = { get foo() { return 1; } }; |
| 8 | 8 |
| 9 function test() | 9 function test() |
| 10 { | 10 { |
| 11 var obj1, obj2; | 11 var obj1, obj2; |
| 12 | 12 |
| 13 function dumpProperties(next, properties) | 13 function dumpProperties(next, properties) |
| 14 { | 14 { |
| 15 for (var i = 0; i < properties.length; ++i) | 15 for (var i = 0; i < properties.length; ++i) |
| 16 dumpProperty(properties[i]); | 16 dumpProperty(properties[i]); |
| 17 next(); | 17 next(); |
| 18 } | 18 } |
| 19 | 19 |
| 20 InspectorTest.runTestSuite([ | 20 InspectorTest.runTestSuite([ |
| 21 function testSetUp(next) | 21 function testSetUp(next) |
| 22 { | 22 { |
| 23 InspectorTest.evaluateInPage("dumpObjects('Initial')", step0); | 23 InspectorTest.evaluateInPage("dumpObjects('Initial')", step0); |
| 24 | 24 |
| 25 function step0() | 25 function step0() |
| 26 { | 26 { |
| 27 InspectorTest.RuntimeAgent.evaluate("object1", step1); | 27 InspectorTest.RuntimeAgent.evaluate("object1", step1); |
| 28 } | 28 } |
| 29 | 29 |
| 30 function step1(error, result, wasThrown) | 30 function step1(error, result) |
|
dgozman
2016/08/11 01:54:35
While you are here, let's add exceptionDetails sec
kozy
2016/08/11 21:04:22
Done.
| |
| 31 { | 31 { |
| 32 obj1 = InspectorTest.runtimeModel.createRemoteObject(result); | 32 obj1 = InspectorTest.runtimeModel.createRemoteObject(result); |
| 33 InspectorTest.RuntimeAgent.evaluate("object2", step2); | 33 InspectorTest.RuntimeAgent.evaluate("object2", step2); |
| 34 } | 34 } |
| 35 | 35 |
| 36 function step2(error, result, wasThrown) | 36 function step2(error, result) |
|
dgozman
2016/08/11 01:54:35
While you are here, let's add exceptionDetails sec
kozy
2016/08/11 21:04:22
Done.
| |
| 37 { | 37 { |
| 38 obj2 = InspectorTest.runtimeModel.createRemoteObject(result); | 38 obj2 = InspectorTest.runtimeModel.createRemoteObject(result); |
| 39 next(); | 39 next(); |
| 40 } | 40 } |
| 41 }, | 41 }, |
| 42 | 42 |
| 43 function testGetterAndSetter(next) | 43 function testGetterAndSetter(next) |
| 44 { | 44 { |
| 45 obj1.getOwnProperties(dumpProperties.bind(this, next)); | 45 obj1.getOwnProperties(dumpProperties.bind(this, next)); |
| 46 }, | 46 }, |
| (...skipping 26 matching lines...) Expand all Loading... | |
| 73 </script> | 73 </script> |
| 74 </head> | 74 </head> |
| 75 | 75 |
| 76 <body onload="runTest()"> | 76 <body onload="runTest()"> |
| 77 <p> | 77 <p> |
| 78 Tests RemoteObject.getProperties. | 78 Tests RemoteObject.getProperties. |
| 79 </p> | 79 </p> |
| 80 | 80 |
| 81 </body> | 81 </body> |
| 82 </html> | 82 </html> |
| OLD | NEW |
