Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
index 2104b894a4f144fa813ab9eef4a1f2c65e90c7ab..0080051ec7a316c41bde13c93ea10fd3de4ffe88 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
@@ -1088,17 +1088,16 @@ WebInspector.DebuggerModel.CallFrame.prototype = {
/**
* @param {?Protocol.Error} error
* @param {!RuntimeAgent.RemoteObject} result
- * @param {boolean=} wasThrown
- * @param {?RuntimeAgent.ExceptionDetails=} exceptionDetails
+ * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
*/
- function didEvaluateOnCallFrame(error, result, wasThrown, exceptionDetails)
+ function didEvaluateOnCallFrame(error, result, exceptionDetails)
{
if (error) {
console.error(error);
callback(null, false);
return;
}
- callback(result, wasThrown, exceptionDetails);
+ callback(result, !!exceptionDetails, exceptionDetails);
}
this._debuggerAgent.evaluateOnCallFrame(this._payload.callFrameId, code, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, didEvaluateOnCallFrame);
},

Powered by Google App Engine
This is Rietveld 408576698