third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html - Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-save-to-temp-var.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

index 4f2a1bdc762a49d0e4fa3eb8a095f8f0f9ee9400..0c949ff485d0979e9cd64d74bbbde1fa51c58ea0 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

@@ -24,7 +24,7 @@ function test()

InspectorTest.assertEquals(snippetId, WebInspector.scriptSnippetModel._snippetIdForSourceURL(evaluationSourceURL), "Snippet can not be identified by its evaluation sourceURL.");

- function dumpResult(target, result, wasThrown)

+ function dumpResult(target, result)

{

InspectorTest.addResult("Snippet execution result: " + result.description);

callback();

@@ -230,7 +230,7 @@ function test()

InspectorTest.addSniffer(WebInspector.ScriptSnippetModel.prototype, "_printRunScriptResult", snippetFinished);

WebInspector.scriptSnippetModel.evaluateScriptSnippet(WebInspector.context.flavor(WebInspector.ExecutionContext), uiSourceCode);

- function snippetFinished(result, wasThrown)

+ function snippetFinished(result)

{

var script = snippetScriptMapping._scriptForUISourceCode.get(uiSourceCode);

InspectorTest.addResult("Snippet execution result: " + result.description);