third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html - Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js ('k') | third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html b/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html

index c6c0b0da8997902acf5551a21fecb5d2ddec94f5..e1e592dd9be3524b8e7492d2587aae3ff49feb2a 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html

+++ b/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html

@@ -10,15 +10,15 @@ function test()

function step2(response)

{

failIfError(response);

- InspectorTest.log("first \"let a = 1;\" result: wasThrown = " + response.result.wasThrown);

+ InspectorTest.log("first \"let a = 1;\" result: wasThrown = " + !!response.result.exceptionDetails);

InspectorTest.sendCommand("Runtime.evaluate", { expression: "let a = 239;" }, step3);

}

function step3(response)

{

failIfError(response);

- InspectorTest.log("second \"let a = 1;\" result: wasThrown = " + response.result.wasThrown);

- if (response.result.wasThrown)

+ InspectorTest.log("second \"let a = 1;\" result: wasThrown = " + !!response.result.exceptionDetails);

+ if (response.result.exceptionDetails)

InspectorTest.log("exception message: " + response.result.exceptionDetails.text);

InspectorTest.sendCommand("Runtime.evaluate", { expression: "a" }, step4);

}