Use BookmarkModelFactory::GetForBrowserContext everywhere

Use BookmarkModelFactory::GetForBrowserContext everywhere

Change all uses of BookmarkModelFactory::GetForProfile[IfExists] to
BookmarkModelFactory::GetForBrowserContext[IfExists].

Remove BookmarkModelFactory::GetForProfile and ::GetForProfileIfExists.

TBR=dbeam@chromium.org
BUG=None

Committed: https://crrev.com/3e0d5c99fed719adaa0c129b73c35faf57e28ad2
Cr-Commit-Position: refs/heads/master@{#410320}

[Philipp Keck, 2016-08-04 17:35:43]

Description was changed from

==========
Use BookmarkModelFactory::GetForBrowserContextIfExists everywhere

Change all uses of BookmarkModelFactory::GetForProfile[IfExists] to
BookmarkModelFactory::GetForBrowserContext[IfExists].

Remove BookmarkModelFactory::GetForProfile and ::GetForProfileIfExists.

BUG=None
==========

to

==========
Use BookmarkModelFactory::GetForBrowserContext everywhere

Change all uses of BookmarkModelFactory::GetForProfile[IfExists] to
BookmarkModelFactory::GetForBrowserContext[IfExists].

Remove BookmarkModelFactory::GetForProfile and ::GetForProfileIfExists.

BUG=None
==========

[Philipp Keck, 2016-08-04 17:45:18]

pke@google.com changed reviewers:
+ sky@chromium.org

[Philipp Keck, 2016-08-04 17:45:19]

PTAL.

Previous discussion in
https://codereview.chromium.org/2184263005/diff/40001/chrome/browser/ui/tab_h...
and
https://codereview.chromium.org/2200113002/diff/120001/chrome/browser/bookmar...

For review, please pay attention to the following changes, which are not plain
replacement of "GetForProfile" with "GetForBrowserContext":
- The diff between patch sets 1 and 2. In some places, I did not only replace
the function call, but also got rid of Profile altogether.
-
https://codereview.chromium.org/2216713002/diff/20001/chrome/browser/ui/webui...
Here a new include was necessary.
-
https://codereview.chromium.org/2216713002/diff/20001/chrome/browser/history/...
Random style fix for presubmit
- The factory itself:
https://codereview.chromium.org/2216713002/diff/20001/chrome/browser/bookmark...
and
https://codereview.chromium.org/2216713002/diff/20001/chrome/browser/bookmark...

Thank you!

[Philipp Keck, 2016-08-04 17:49:27]

pke@google.com changed reviewers:
+ bauerb@chromium.org

[Philipp Keck, 2016-08-04 17:49:28]

bauerb@chromium.org: Please review changes in
chrome/browser/ui/webui/browsing_history_handler.cc

[sky, 2016-08-04 20:09:13]

LGTM

https://codereview.chromium.org/2216713002/diff/20001/chrome/browser/history/...
File chrome/browser/history/android/android_history_provider_service_unittest.cc
(right):

https://codereview.chromium.org/2216713002/diff/20001/chrome/browser/history/...
chrome/browser/history/android/android_history_provider_service_unittest.cc:69:
testing_profile_ = NULL;
If you're going to change this you may as well update to nullptr.

[sky, 2016-08-04 20:15:55]

And thanks for the cleanup!

[Philipp Keck, 2016-08-05 07:57:17]

https://codereview.chromium.org/2216713002/diff/20001/chrome/browser/history/...
File chrome/browser/history/android/android_history_provider_service_unittest.cc
(right):

https://codereview.chromium.org/2216713002/diff/20001/chrome/browser/history/...
chrome/browser/history/android/android_history_provider_service_unittest.cc:69:
testing_profile_ = NULL;
On 2016/08/04 20:09:13, sky wrote:
> If you're going to change this you may as well update to nullptr.

Done.

[Bernhard Bauer, 2016-08-05 08:49:44]

lgtm

[Philipp Keck, 2016-08-05 09:46:21]

Description was changed from

==========
Use BookmarkModelFactory::GetForBrowserContext everywhere

Change all uses of BookmarkModelFactory::GetForProfile[IfExists] to
BookmarkModelFactory::GetForBrowserContext[IfExists].

Remove BookmarkModelFactory::GetForProfile and ::GetForProfileIfExists.

BUG=None
==========

to

==========
Use BookmarkModelFactory::GetForBrowserContext everywhere

Change all uses of BookmarkModelFactory::GetForProfile[IfExists] to
BookmarkModelFactory::GetForBrowserContext[IfExists].

Remove BookmarkModelFactory::GetForProfile and ::GetForProfileIfExists.

TBR=dbeam@chromium.org
BUG=None
==========

[Philipp Keck, 2016-08-05 12:19:01]

The CQ bit was checked by pke@google.com

[Philipp Keck, 2016-08-05 12:19:02]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2216713002/#ps40001
(title: "Change NULL to nullptr")

[commit-bot: I haz the power, 2016-08-05 12:19:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 12:30:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 12:30:33]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Philipp Keck, 2016-08-05 12:53:36]

The CQ bit was checked by pke@google.com

[Philipp Keck, 2016-08-05 12:53:36]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2216713002/#ps60001
(title: "Rebase and more includes")

[commit-bot: I haz the power, 2016-08-05 12:53:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 13:21:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 13:22:01]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Philipp Keck, 2016-08-08 08:13:48]

On 2016/08/05 13:22:01, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

fyi, I also had to adjust a couple of mm files. It was plain text replacement
there, no special cases.

[Philipp Keck, 2016-08-08 08:14:07]

The CQ bit was checked by pke@google.com

[Philipp Keck, 2016-08-08 08:14:08]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2216713002/#ps80001
(title: "Replace in .mm files")

[commit-bot: I haz the power, 2016-08-08 08:14:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 09:07:46]

Description was changed from

==========
Use BookmarkModelFactory::GetForBrowserContext everywhere

Change all uses of BookmarkModelFactory::GetForProfile[IfExists] to
BookmarkModelFactory::GetForBrowserContext[IfExists].

Remove BookmarkModelFactory::GetForProfile and ::GetForProfileIfExists.

TBR=dbeam@chromium.org
BUG=None
==========

to

==========
Use BookmarkModelFactory::GetForBrowserContext everywhere

Change all uses of BookmarkModelFactory::GetForProfile[IfExists] to
BookmarkModelFactory::GetForBrowserContext[IfExists].

Remove BookmarkModelFactory::GetForProfile and ::GetForProfileIfExists.

TBR=dbeam@chromium.org
BUG=None
==========

[commit-bot: I haz the power, 2016-08-08 09:07:48]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-08 09:09:56]

Description was changed from

==========
Use BookmarkModelFactory::GetForBrowserContext everywhere

Change all uses of BookmarkModelFactory::GetForProfile[IfExists] to
BookmarkModelFactory::GetForBrowserContext[IfExists].

Remove BookmarkModelFactory::GetForProfile and ::GetForProfileIfExists.

TBR=dbeam@chromium.org
BUG=None
==========

to

==========
Use BookmarkModelFactory::GetForBrowserContext everywhere

Change all uses of BookmarkModelFactory::GetForProfile[IfExists] to
BookmarkModelFactory::GetForBrowserContext[IfExists].

Remove BookmarkModelFactory::GetForProfile and ::GetForProfileIfExists.

TBR=dbeam@chromium.org
BUG=None

Committed: https://crrev.com/3e0d5c99fed719adaa0c129b73c35faf57e28ad2
Cr-Commit-Position: refs/heads/master@{#410320}
==========

[commit-bot: I haz the power, 2016-08-08 09:09:58]

Patchset 5 (id:??) landed as
https://crrev.com/3e0d5c99fed719adaa0c129b73c35faf57e28ad2
Cr-Commit-Position: refs/heads/master@{#410320}