Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/bookmarks/bookmark_model_factory.h

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks
Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_FACTORY_H_ 5 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_FACTORY_H_
6 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_FACTORY_H_ 6 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_FACTORY_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/keyed_service/content/browser_context_keyed_service_factory .h" 9 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"
10 10
11 namespace base { 11 namespace base {
12 template <typename T> struct DefaultSingletonTraits; 12 template <typename T> struct DefaultSingletonTraits;
13 } 13 }
14 14
15 class Profile;
16
17 namespace bookmarks { 15 namespace bookmarks {
18 class BookmarkModel; 16 class BookmarkModel;
19 } 17 }
20 18
21 // Singleton that owns all BookmarkModels and associates them with Profiles. 19 // Singleton that owns all BookmarkModels and associates them with
20 // BrowserContexts.
22 class BookmarkModelFactory : public BrowserContextKeyedServiceFactory { 21 class BookmarkModelFactory : public BrowserContextKeyedServiceFactory {
23 public: 22 public:
24 static bookmarks::BookmarkModel* GetForBrowserContext( 23 static bookmarks::BookmarkModel* GetForBrowserContext(
25 content::BrowserContext* browser_context); 24 content::BrowserContext* browser_context);
26 25
27 static bookmarks::BookmarkModel* GetForBrowserContextIfExists( 26 static bookmarks::BookmarkModel* GetForBrowserContextIfExists(
28 content::BrowserContext* browser_context); 27 content::BrowserContext* browser_context);
29 28
30 // TODO(pke): Remove GetForProfile and GetForProfileIfExists and use
31 // GetForBrowserContext/GetForBrowserContextIfExists everywhere.
32 static bookmarks::BookmarkModel* GetForProfile(Profile* profile);
33
34 static bookmarks::BookmarkModel* GetForProfileIfExists(Profile* profile);
35
36 static BookmarkModelFactory* GetInstance(); 29 static BookmarkModelFactory* GetInstance();
37 30
38 private: 31 private:
39 friend struct base::DefaultSingletonTraits<BookmarkModelFactory>; 32 friend struct base::DefaultSingletonTraits<BookmarkModelFactory>;
40 33
41 BookmarkModelFactory(); 34 BookmarkModelFactory();
42 ~BookmarkModelFactory() override; 35 ~BookmarkModelFactory() override;
43 36
44 // BrowserContextKeyedServiceFactory: 37 // BrowserContextKeyedServiceFactory:
45 KeyedService* BuildServiceInstanceFor( 38 KeyedService* BuildServiceInstanceFor(
46 content::BrowserContext* context) const override; 39 content::BrowserContext* context) const override;
47 void RegisterProfilePrefs( 40 void RegisterProfilePrefs(
48 user_prefs::PrefRegistrySyncable* registry) override; 41 user_prefs::PrefRegistrySyncable* registry) override;
49 content::BrowserContext* GetBrowserContextToUse( 42 content::BrowserContext* GetBrowserContextToUse(
50 content::BrowserContext* context) const override; 43 content::BrowserContext* context) const override;
51 bool ServiceIsNULLWhileTesting() const override; 44 bool ServiceIsNULLWhileTesting() const override;
52 45
53 DISALLOW_COPY_AND_ASSIGN(BookmarkModelFactory); 46 DISALLOW_COPY_AND_ASSIGN(BookmarkModelFactory);
54 }; 47 };
55 48
56 #endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_FACTORY_H_ 49 #endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698