chrome/browser/ui/browser_commands.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Replace in .mm files Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc ('k') | chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index 8a77489e6fc1be74f317155d4657a0a112fb6b48..b67422e8813b4357dd4fb7e8d519562ef93ba8b7 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -132,7 +132,7 @@ namespace {

bool CanBookmarkCurrentPageInternal(const Browser* browser,

bool check_remove_bookmark_ui) {

BookmarkModel* model =

- BookmarkModelFactory::GetForProfile(browser->profile());

+ BookmarkModelFactory::GetForBrowserContext(browser->profile());

return browser_defaults::bookmarks_enabled &&

browser->profile()->GetPrefs()->GetBoolean(

bookmarks::prefs::kEditBookmarksEnabled) &&

@@ -727,7 +727,7 @@ void BookmarkCurrentPageIgnoringExtensionOverrides(Browser* browser) {

content::RecordAction(UserMetricsAction("Star"));

BookmarkModel* model =

- BookmarkModelFactory::GetForProfile(browser->profile());

+ BookmarkModelFactory::GetForBrowserContext(browser->profile());

if (!model || !model->loaded())

return; // Ignore requests until bookmarks are loaded.