chrome/browser/ui/sync/profile_signin_confirmation_helper.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Replace in .mm files Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view_browsertest.cc ('k') | chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

diff --git a/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc b/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

index 8d3818baffb3fad93816e71bf366263dc315b755..bd9625241f6984df0f4c3d1b5433c590e9b1120b 100644

--- a/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

+++ b/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

@@ -33,7 +33,8 @@ namespace {

const int kHistoryEntriesBeforeNewProfilePrompt = 10;

bool HasBookmarks(Profile* profile) {

- BookmarkModel* bookmarks = BookmarkModelFactory::GetForProfile(profile);

+ BookmarkModel* bookmarks =

+ BookmarkModelFactory::GetForBrowserContext(profile);

bool has_bookmarks = bookmarks && bookmarks->HasBookmarks();

if (has_bookmarks)

DVLOG(1) << "SigninConfirmationHelper: profile contains bookmarks";