chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Replace in .mm files Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

index dd75c04a06337a1903318b44fb0d5f840f9aec6f..43648fb1bdcb773e151c6482ce66613d3c965343 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

@@ -342,7 +342,7 @@ NSString* const kOkEnabledName = @"okEnabled";

#pragma mark Folder Tree Management

- (BookmarkModel*)bookmarkModel {

- return BookmarkModelFactory::GetForProfile(profile_);

+ return BookmarkModelFactory::GetForBrowserContext(profile_);

}

- (Profile*)profile {

@@ -481,7 +481,7 @@ NSString* const kOkEnabledName = @"okEnabled";

// of ancestor nodes. Then crawl down the folderTreeArray looking

// for each ancestor in order while building up the selectionPath.

std::stack<const BookmarkNode*> nodeStack;

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile_);

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile_);

const BookmarkNode* rootNode = model->root_node();

const BookmarkNode* node = desiredNode;

while (node != rootNode) {

@@ -539,7 +539,7 @@ NSString* const kOkEnabledName = @"okEnabled";

- (void)buildFolderTree {

// Build up a tree of the current folder configuration.

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile_);

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile_);

const BookmarkNode* rootNode = model->root_node();

NSMutableArray* baseArray = [self addChildFoldersFromNode:rootNode];

DCHECK(baseArray);