chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Replace in .mm files Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm

index b0d8d40342f30d13ad71f193033866bd9955cf1a..528969bd647b2fe8ec88e3a6e3f6689525b59940 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm

@@ -223,7 +223,7 @@ TEST_F(BookmarkBarViewTest, BookmarkButtonDragAndDrop) {

[info reset];

BookmarkModel* bookmark_model =

- BookmarkModelFactory::GetForProfile(profile());

+ BookmarkModelFactory::GetForBrowserContext(profile());

const BookmarkNode* node =

bookmark_model->AddURL(bookmark_model->bookmark_bar_node(),

@@ -264,7 +264,7 @@ TEST_F(BookmarkBarViewTest, BookmarkButtonDragAndDropAcrossProfiles) {

other_profile->CreateBookmarkModel(true);

BookmarkModel* bookmark_model =

- BookmarkModelFactory::GetForProfile(profile());

+ BookmarkModelFactory::GetForBrowserContext(profile());

bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model);

const BookmarkNode* node =

@@ -285,7 +285,8 @@ TEST_F(BookmarkBarViewTest, BookmarkButtonDragAndDropAcrossProfiles) {

[info setDragDataType:ui::ClipboardUtil::UTIForPasteboardType(

kBookmarkButtonDragType)];

[info setButton:dragged_button.get()];

- [info setBookmarkModel:BookmarkModelFactory::GetForProfile(other_profile)];

+ [info setBookmarkModel:BookmarkModelFactory::GetForBrowserContext(

+ other_profile)];

EXPECT_EQ([view_ draggingEntered:(id)info.get()], NSDragOperationMove);

EXPECT_TRUE([view_ performDragOperation:(id)info.get()]);

EXPECT_TRUE([info dragButtonToPong]);