chrome/browser/ntp_snippets/content_suggestions_service_factory.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Replace in .mm files Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

diff --git a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

index 0dc8e0a2b728aaddf1ec4533f158b34ebdfeee9b..942343b808ea5ec37adbd8fa00d7c794a2c78bae 100644

--- a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

+++ b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

@@ -127,9 +127,8 @@ KeyedService* ContentSuggestionsServiceFactory::BuildServiceInstanceFor(

// Create the BookmarkSuggestionsProvider.

if (base::FeatureList::IsEnabled(

ntp_snippets::kBookmarkSuggestionsFeature)) {

- // TODO(pke): GetForBrowserContext

BookmarkModel* bookmark_model =

- BookmarkModelFactory::GetForProfile(profile);

+ BookmarkModelFactory::GetForBrowserContext(profile);

std::unique_ptr<BookmarkSuggestionsProvider> bookmark_suggestions_provider =

base::MakeUnique<BookmarkSuggestionsProvider>(

service, service->category_factory(), bookmark_model);

« no previous file with comments | « chrome/browser/importer/profile_writer_unittest.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »