chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Replace in .mm files Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

index 4d4ca0eebaf31de7fc86e9699129ed23b220c2df..6f9436a7c0c521ce24921d1dff00966e90a6601f 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

@@ -82,7 +82,7 @@ using bookmarks::BookmarkNode;

- (void)runAsModalSheet {

// Ping me when things change out from under us.

observer_.reset(new BookmarkModelObserverForCocoa(

- BookmarkModelFactory::GetForProfile(profile_), ^() {

+ BookmarkModelFactory::GetForBrowserContext(profile_), ^() {

[self cancel:nil];

}));

observer_->StartObservingNode(node_);

@@ -101,7 +101,7 @@ using bookmarks::BookmarkNode;

NSString* name = [nameField_ stringValue];

if ([name length] == 0)

name = l10n_util::GetNSStringWithFixup(IDS_BOOKMARK_EDITOR_NEW_FOLDER_NAME);

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile_);

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile_);

if (node_) {

model->SetTitle(node_, base::SysNSStringToUTF16(name));

} else {