[New CL] Add a tab helper to record the last visit date for each bookmark

chrome/browser/bookmarks/bookmark_model_factory.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_FACTORY_H_
 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_FACTORY_H_
 
 #include "base/macros.h"
 #include "components/keyed_service/content/browser_context_keyed_service_factory.h"
 
 namespace base {
 template <typename T> struct DefaultSingletonTraits;
 }
 
 class Profile;
 
 namespace bookmarks {
 class BookmarkModel;
 }
 
 // Singleton that owns all BookmarkModels and associates them with Profiles.
 class BookmarkModelFactory : public BrowserContextKeyedServiceFactory {
  public:
+  static bookmarks::BookmarkModel* GetForBrowserContext(
+      content::BrowserContext* context);
+
   static bookmarks::BookmarkModel* GetForProfile(Profile* profile);

[sky, 2016/08/03 19:30:27]

Remove this and convert to using new functions.

[Philipp Keck, 2016/08/04 11:25:48]

Ok. Since that will affect almost 100 places in the codebase and because we have
feature freeze coming up with a couple of other CLs depending on this one, I'd
like to do these changes in a separate CL.

I added a GetForBrowserContextIfExists for consistency, and a TODO(pke) comment
for removing GetForProfile[IfExists]. The new CL will follow very soon, at the
latest right after feature freeze. I hope we can merge this CL as is -- or do
you need me to remove the two new methods for now and reinsert them later?

 
   static bookmarks::BookmarkModel* GetForProfileIfExists(Profile* profile);
 
   static BookmarkModelFactory* GetInstance();
 
  private:
   friend struct base::DefaultSingletonTraits<BookmarkModelFactory>;
 
   BookmarkModelFactory();
   ~BookmarkModelFactory() override;
 
   // BrowserContextKeyedServiceFactory:
   KeyedService* BuildServiceInstanceFor(
       content::BrowserContext* context) const override;
   void RegisterProfilePrefs(
       user_prefs::PrefRegistrySyncable* registry) override;
   content::BrowserContext* GetBrowserContextToUse(
       content::BrowserContext* context) const override;
   bool ServiceIsNULLWhileTesting() const override;
 
   DISALLOW_COPY_AND_ASSIGN(BookmarkModelFactory);
 };
 
 #endif  // CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_FACTORY_H_