chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Replace in .mm files Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm

index d83d85f93472c36b44a9e72c3626a7cca05b329f..04b14932e0bf339a844f82061f6acec2305cc0c5 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm

@@ -99,7 +99,7 @@ TEST_F(BookmarkButtonCellTest, MouseEnterStuff) {

[cell setMenu:[[[NSMenu alloc] initWithTitle:@"foo"] autorelease]];

EXPECT_FALSE([cell menu]);

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile());

const BookmarkNode* node = model->bookmark_bar_node();

[cell setEmpty:NO];

[cell setBookmarkNode:node];

@@ -110,7 +110,7 @@ TEST_F(BookmarkButtonCellTest, MouseEnterStuff) {

}

TEST_F(BookmarkButtonCellTest, BookmarkNode) {

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile());

base::scoped_nsobject<BookmarkButtonCell> cell(

[[BookmarkButtonCell alloc] initTextCell:@"Testing"]);

@@ -160,7 +160,7 @@ TEST_F(BookmarkButtonCellTest, Awake) {

// Subfolder arrow details.

TEST_F(BookmarkButtonCellTest, FolderArrow) {

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile());

const BookmarkNode* bar = model->bookmark_bar_node();

const BookmarkNode* node = model->AddURL(bar, bar->child_count(),

base::ASCIIToUTF16("title"),

@@ -184,7 +184,7 @@ TEST_F(BookmarkButtonCellTest, FolderArrow) {

}

TEST_F(BookmarkButtonCellTest, VerticalTextOffset) {

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile());

const BookmarkNode* bar = model->bookmark_bar_node();

const BookmarkNode* node = model->AddURL(bar, bar->child_count(),

base::ASCIIToUTF16("title"),