chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Replace in .mm files Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

index c91486867fc7d5300ddd8b2c540978c4051e820a..ea9e7f7f4bbfcf374f7de35fc7ce217d8a06ded9 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

@@ -82,7 +82,8 @@ class BookmarkBubbleControllerTest : public CocoaProfileTest {

[controller_ close];

controller_ = nil;

}

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());

+ BookmarkModel* model =

+ BookmarkModelFactory::GetForBrowserContext(profile());

bookmarks::ManagedBookmarkService* managed =

ManagedBookmarkServiceFactory::GetForProfile(profile());

controller_ = [[BookmarkBubbleController alloc]

@@ -101,7 +102,7 @@ class BookmarkBubbleControllerTest : public CocoaProfileTest {

}

BookmarkModel* GetBookmarkModel() {

- return BookmarkModelFactory::GetForProfile(profile());

+ return BookmarkModelFactory::GetForBrowserContext(profile());

}

const BookmarkNode* CreateTestBookmark() {

@@ -391,7 +392,7 @@ TEST_F(BookmarkBubbleControllerTest, PopUpSelectionChanged) {

// the user clicking the star, then sending the "cancel" command to represent

// them pressing escape. The bookmark should not be there.

TEST_F(BookmarkBubbleControllerTest, EscapeRemovesNewBookmark) {

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile());

bookmarks::ManagedBookmarkService* managed =

ManagedBookmarkServiceFactory::GetForProfile(profile());

const BookmarkNode* node = CreateTestBookmark();