chrome/browser/history/history_service_factory.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_service_factory.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Replace in .mm files Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/android/sqlite_cursor_unittest.cc ('k') | chrome/browser/importer/external_process_importer_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_service_factory.cc

diff --git a/chrome/browser/history/history_service_factory.cc b/chrome/browser/history/history_service_factory.cc

index 30f9f3ecef1f2ab8459f4b1105d78cc78e353f38..ae573881e9f6aa76fbba66440ad33f617f5f9c3e 100644

--- a/chrome/browser/history/history_service_factory.cc

+++ b/chrome/browser/history/history_service_factory.cc

@@ -77,14 +77,13 @@ HistoryServiceFactory::~HistoryServiceFactory() {

KeyedService* HistoryServiceFactory::BuildServiceInstanceFor(

content::BrowserContext* context) const {

- Profile* profile = Profile::FromBrowserContext(context);

std::unique_ptr<history::HistoryService> history_service(

new history::HistoryService(

base::WrapUnique(new ChromeHistoryClient(

- BookmarkModelFactory::GetForProfile(profile))),

- base::WrapUnique(new history::ContentVisitDelegate(profile))));

+ BookmarkModelFactory::GetForBrowserContext(context))),

+ base::WrapUnique(new history::ContentVisitDelegate(context))));

if (!history_service->Init(

- history::HistoryDatabaseParamsForPath(profile->GetPath()))) {

+ history::HistoryDatabaseParamsForPath(context->GetPath()))) {

return nullptr;

}

return history_service.release();