chrome/browser/sync/chrome_sync_client.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/chrome_sync_client.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Replace in .mm files Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/storage/durable_storage_permission_context.cc ('k') | chrome/browser/sync/test/integration/bookmarks_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/chrome_sync_client.cc

diff --git a/chrome/browser/sync/chrome_sync_client.cc b/chrome/browser/sync/chrome_sync_client.cc

index 5396628e76467401f022a72cc4212de40f86a750..a18215d336ee51fcf2dbe6884039830924d267f7 100644

--- a/chrome/browser/sync/chrome_sync_client.cc

+++ b/chrome/browser/sync/chrome_sync_client.cc

@@ -137,7 +137,7 @@ class SyncSessionsClientImpl : public sync_sessions::SyncSessionsClient {

// SyncSessionsClient implementation.

bookmarks::BookmarkModel* GetBookmarkModel() override {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

- return BookmarkModelFactory::GetForProfile(profile_);

+ return BookmarkModelFactory::GetForBrowserContext(profile_);

}

favicon::FaviconService* GetFaviconService() override {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

@@ -230,7 +230,7 @@ PrefService* ChromeSyncClient::GetPrefService() {

bookmarks::BookmarkModel* ChromeSyncClient::GetBookmarkModel() {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- return BookmarkModelFactory::GetForProfile(profile_);

+ return BookmarkModelFactory::GetForBrowserContext(profile_);

}

favicon::FaviconService* ChromeSyncClient::GetFaviconService() {