Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed)

Created:
4 years, 5 months ago by tzik
Modified:
4 years, 4 months ago
Reviewers:
haraken, kinuko, esprehn, yhirano
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jam, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gmock_cxx11
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader WebDataConsumerHandle::obtainReader was split into obtainReader and obtainReaderInternal just to hide WTF::OwnPtr in public/platform. Since all WTF::OwnPtr is replaced with std::unique_ptr, there's no reason to have them separately. BUG=624696 Committed: https://crrev.com/ee30ec4e77a15b515e58ed8123c78c2d0692c613 Cr-Commit-Position: refs/heads/master@{#408070}

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : rebase #

Patch Set 4 : +use C++11 explicitly #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -250 lines) Patch
M content/child/shared_memory_data_consumer_handle.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/shared_memory_data_consumer_handle.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M content/child/shared_memory_data_consumer_handle_unittest.cc View 29 chunks +29 lines, -29 lines 0 comments Download
M content/child/web_data_consumer_handle_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/web_data_consumer_handle_impl.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M content/child/web_data_consumer_handle_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandleTest.cpp View 1 5 chunks +22 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.cpp View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp View 1 5 chunks +17 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchDataConsumerHandle.h View 1 chunk +2 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/modules/fetch/FetchDataConsumerHandle.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp View 1 20 chunks +60 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp View 14 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp View 11 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebDataConsumerHandle.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/public/platform/WebDataConsumerHandle.h View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 37 (28 generated)
tzik
PTAL
4 years, 5 months ago (2016-07-25 05:31:56 UTC) #23
yhirano
lgtm, thanks.
4 years, 5 months ago (2016-07-26 06:35:19 UTC) #24
haraken
WebKit LGTM
4 years, 5 months ago (2016-07-26 08:12:32 UTC) #25
tzik
+esprehn as a //content/child and platform OWNER. PTAL to them?
4 years, 5 months ago (2016-07-26 08:14:27 UTC) #27
kinuko
Drive-by lgtm for content and platform.
4 years, 4 months ago (2016-07-26 14:30:28 UTC) #28
esprehn
lgtm
4 years, 4 months ago (2016-07-26 17:27:34 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172183003/100001
4 years, 4 months ago (2016-07-27 04:06:02 UTC) #33
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-07-27 07:15:23 UTC) #35
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 07:17:51 UTC) #37
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ee30ec4e77a15b515e58ed8123c78c2d0692c613
Cr-Commit-Position: refs/heads/master@{#408070}

Powered by Google App Engine
This is Rietveld 408576698