third_party/WebKit/Source/platform/exported/WebDataConsumerHandle.cpp - Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebDataConsumerHandle.cpp

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock_cxx11

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/exported/WebDataConsumerHandle.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebDataConsumerHandle.cpp b/third_party/WebKit/Source/platform/exported/WebDataConsumerHandle.cpp

index 5c870213adb2f7de05d8be7a6ddaae22fa49bbe0..2f4b2b4d67941c5f18cc22127bfd2d64967fba97 100644

--- a/third_party/WebKit/Source/platform/exported/WebDataConsumerHandle.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebDataConsumerHandle.cpp

@@ -22,12 +22,6 @@ WebDataConsumerHandle::~WebDataConsumerHandle()

ASSERT(ThreadState::current());

}

-std::unique_ptr<WebDataConsumerHandle::Reader> WebDataConsumerHandle::obtainReader(WebDataConsumerHandle::Client* client)

- ASSERT(ThreadState::current());

- return wrapUnique(obtainReaderInternal(client));

WebDataConsumerHandle::Result WebDataConsumerHandle::Reader::read(void* data, size_t size, Flags flags, size_t* readSize)

{

*readSize = 0;

@@ -42,4 +36,3 @@ WebDataConsumerHandle::Result WebDataConsumerHandle::Reader::read(void* data, si

}

} // namespace blink

« no previous file with comments | « third_party/WebKit/Source/modules/modules.gypi ('k') | third_party/WebKit/public/platform/WebDataConsumerHandle.h » ('j') | no next file with comments »