Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: content/child/web_data_consumer_handle_impl.h

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock_cxx11
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_CHILD_WEB_DATA_CONSUMER_HANDLE_IMPL_H_ 5 #ifndef CONTENT_CHILD_WEB_DATA_CONSUMER_HANDLE_IMPL_H_
6 #define CONTENT_CHILD_WEB_DATA_CONSUMER_HANDLE_IMPL_H_ 6 #define CONTENT_CHILD_WEB_DATA_CONSUMER_HANDLE_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 26 matching lines...) Expand all
37 37
38 private: 38 private:
39 Result HandleReadResult(MojoResult); 39 Result HandleReadResult(MojoResult);
40 void StartWatching(); 40 void StartWatching();
41 void OnHandleGotReadable(MojoResult); 41 void OnHandleGotReadable(MojoResult);
42 42
43 scoped_refptr<Context> context_; 43 scoped_refptr<Context> context_;
44 mojo::Watcher handle_watcher_; 44 mojo::Watcher handle_watcher_;
45 Client* client_; 45 Client* client_;
46 }; 46 };
47 std::unique_ptr<Reader> ObtainReader(Client* client); 47 std::unique_ptr<Reader> obtainReader(Client* client) override;
48 48
49 explicit WebDataConsumerHandleImpl(Handle handle); 49 explicit WebDataConsumerHandleImpl(Handle handle);
50 ~WebDataConsumerHandleImpl() override; 50 ~WebDataConsumerHandleImpl() override;
51 51
52 private: 52 private:
53 ReaderImpl* obtainReaderInternal(Client* client) override;
54 const char* debugName() const override; 53 const char* debugName() const override;
55 54
56 scoped_refptr<Context> context_; 55 scoped_refptr<Context> context_;
57 }; 56 };
58 57
59 } // namespace content 58 } // namespace content
60 59
61 #endif // CONTENT_CHILD_WEB_DATA_CONSUMER_HANDLE_IMPL_H_ 60 #endif // CONTENT_CHILD_WEB_DATA_CONSUMER_HANDLE_IMPL_H_
OLDNEW
« no previous file with comments | « content/child/shared_memory_data_consumer_handle_unittest.cc ('k') | content/child/web_data_consumer_handle_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698