content/child/shared_memory_data_consumer_handle.h - Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/shared_memory_data_consumer_handle.h

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock_cxx11

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/shared_memory_data_consumer_handle.h

diff --git a/content/child/shared_memory_data_consumer_handle.h b/content/child/shared_memory_data_consumer_handle.h

index 4da9fd1a00a378afa80aa0b00ced809b8fe95d45..0a98b760aa7d492b4bce56346173ec25dbed55a4 100644

--- a/content/child/shared_memory_data_consumer_handle.h

+++ b/content/child/shared_memory_data_consumer_handle.h

@@ -81,10 +81,9 @@ class CONTENT_EXPORT SharedMemoryDataConsumerHandle final

std::unique_ptr<Writer>* writer);

~SharedMemoryDataConsumerHandle() override;

- std::unique_ptr<Reader> ObtainReader(Client* client);

+ std::unique_ptr<Reader> obtainReader(Client* client) override;

private:

- ReaderImpl* obtainReaderInternal(Client* client) override;

const char* debugName() const override;

scoped_refptr<Context> context_;

« no previous file with comments | « no previous file | content/child/shared_memory_data_consumer_handle.cc » ('j') | no next file with comments »