third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp - Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock_cxx11

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h ('k') | third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp

index b5cc67c844673ce6b2646c31c68f84771f0c178c..5a906d0046dd44ca7f5d7c7c892a0e67e762931e 100644

--- a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp

+++ b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp

@@ -221,9 +221,9 @@ DataConsumerHandleTestUtil::ReplayingHandle::~ReplayingHandle()

m_context->detachHandle();

}

-WebDataConsumerHandle::Reader* DataConsumerHandleTestUtil::ReplayingHandle::obtainReaderInternal(Client* client)

+std::unique_ptr<WebDataConsumerHandle::Reader> DataConsumerHandleTestUtil::ReplayingHandle::obtainReader(Client* client)

{

- return new ReaderImpl(m_context, client);

+ return WTF::wrapUnique(new ReaderImpl(m_context, client));

}

void DataConsumerHandleTestUtil::ReplayingHandle::add(const Command& command)