Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchDataConsumerHandle.h

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock_cxx11
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/FetchDataConsumerHandle.h
diff --git a/third_party/WebKit/Source/modules/fetch/FetchDataConsumerHandle.h b/third_party/WebKit/Source/modules/fetch/FetchDataConsumerHandle.h
index 608ec91319d03ab766406d36e4afcabe55ce342e..547c06e4c1070e0f239e5075a32733b8f1322734 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchDataConsumerHandle.h
+++ b/third_party/WebKit/Source/modules/fetch/FetchDataConsumerHandle.h
@@ -63,13 +63,8 @@ public:
virtual PassRefPtr<EncodedFormData> drainAsFormData() { return nullptr; }
};
- // TODO(yhirano): obtainReader() is currently non-virtual override, and
- // will be changed into virtual override when we can use unique_ptr in
- // Blink.
- std::unique_ptr<Reader> obtainReader(Client* client) { return wrapUnique(obtainReaderInternal(client)); }
-
-private:
- Reader* obtainReaderInternal(Client*) override = 0;
+ std::unique_ptr<WebDataConsumerHandle::Reader> obtainReader(Client*) final;
+ virtual std::unique_ptr<Reader> obtainFetchDataReader(Client*) = 0;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698