content/child/web_data_consumer_handle_impl.h - Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/web_data_consumer_handle_impl.h

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock_cxx11

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/shared_memory_data_consumer_handle_unittest.cc ('k') | content/child/web_data_consumer_handle_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/web_data_consumer_handle_impl.h

diff --git a/content/child/web_data_consumer_handle_impl.h b/content/child/web_data_consumer_handle_impl.h

index 44409ce580b3868627f2c9fb4dbda785244f59bc..1c93bcd5e5280ecf8e927895798ea4613e11c299 100644

--- a/content/child/web_data_consumer_handle_impl.h

+++ b/content/child/web_data_consumer_handle_impl.h

@@ -44,13 +44,12 @@ class CONTENT_EXPORT WebDataConsumerHandleImpl final

mojo::Watcher handle_watcher_;

Client* client_;

};

- std::unique_ptr<Reader> ObtainReader(Client* client);

+ std::unique_ptr<Reader> obtainReader(Client* client) override;

explicit WebDataConsumerHandleImpl(Handle handle);

~WebDataConsumerHandleImpl() override;

private:

- ReaderImpl* obtainReaderInternal(Client* client) override;

const char* debugName() const override;

scoped_refptr<Context> context_;

« no previous file with comments | « content/child/shared_memory_data_consumer_handle_unittest.cc ('k') | content/child/web_data_consumer_handle_impl.cc » ('j') | no next file with comments »