third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp - Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock_cxx11

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.h ('k') | third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

index 554a1e6de154723abbead1e8afc21c2a8c125809..bbfc917052e078b816cc3c646fa04c7ed86b20e1 100644

--- a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

+++ b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

@@ -293,9 +293,9 @@ ReadableStreamDataConsumerHandle::ReadableStreamDataConsumerHandle(ScriptState*

}

ReadableStreamDataConsumerHandle::~ReadableStreamDataConsumerHandle() = default;

-FetchDataConsumerHandle::Reader* ReadableStreamDataConsumerHandle::obtainReaderInternal(Client* client)

+std::unique_ptr<FetchDataConsumerHandle::Reader> ReadableStreamDataConsumerHandle::obtainFetchDataReader(Client* client)

{

- return new ReadingContext::ReaderImpl(m_readingContext, client);

+ return WTF::wrapUnique(new ReadingContext::ReaderImpl(m_readingContext, client));

}

} // namespace blink