third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp - Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock_cxx11

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchDataConsumerHandle.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp b/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp

index abf39003580d577ffa2166c50f44b87151ce5324..5a491d0024a46831b54bb985e05494a72e98b335 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp

@@ -37,7 +37,7 @@ private:

m_client = client;

- m_reader = handle->obtainReader(this);

+ m_reader = handle->obtainFetchDataReader(this);

RefPtr<BlobDataHandle> blobHandle = m_reader->drainAsBlobDataHandle();

if (blobHandle) {

ASSERT(blobHandle->size() != UINT64_MAX);

@@ -131,7 +131,7 @@ protected:

ASSERT(!m_reader);

m_client = client;

m_rawData = wrapUnique(new ArrayBufferBuilder());

- m_reader = handle->obtainReader(this);

+ m_reader = handle->obtainFetchDataReader(this);

}

void didGetReadable() override

@@ -220,7 +220,7 @@ protected:

ASSERT(!m_reader);

m_client = client;

m_decoder = TextResourceDecoder::createAlwaysUseUTF8ForText();

- m_reader = handle->obtainReader(this);

+ m_reader = handle->obtainFetchDataReader(this);

}

void didGetReadable() override

@@ -307,7 +307,7 @@ protected:

ASSERT(!m_client);

ASSERT(!m_reader);

m_client = client;

- m_reader = handle->obtainReader(this);

+ m_reader = handle->obtainFetchDataReader(this);

}

void didGetReadable() override