Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: third_party/WebKit/public/platform/WebDataConsumerHandle.h

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock_cxx11
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebDataConsumerHandle.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebDataConsumerHandle.h
diff --git a/third_party/WebKit/public/platform/WebDataConsumerHandle.h b/third_party/WebKit/public/platform/WebDataConsumerHandle.h
index 4632ff9ac260e7351172a781cf1e25a94d9f4f69..d1ef789ad75edf63d473ca1b95e49cc04a9277b8 100644
--- a/third_party/WebKit/public/platform/WebDataConsumerHandle.h
+++ b/third_party/WebKit/public/platform/WebDataConsumerHandle.h
@@ -6,10 +6,7 @@
#define WebDataConsumerHandle_h
#include <stddef.h>
-
-#if INSIDE_BLINK
#include <memory>
-#endif
#include "public/platform/WebCommon.h"
@@ -103,16 +100,10 @@ public:
// if |client| is not null.
// If |client| is not null and the handle is not waiting, client
// notification is called asynchronously.
-#if INSIDE_BLINK
- std::unique_ptr<Reader> obtainReader(Client*);
-#endif
+ virtual std::unique_ptr<Reader> obtainReader(Client*) = 0;
// Returns a string literal (e.g. class name) for debugging only.
virtual const char* debugName() const = 0;
-
-private:
- // The caller takes ownership of the returned object.
- virtual Reader* obtainReaderInternal(Client*) = 0;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebDataConsumerHandle.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698