Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.cpp

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock_cxx11
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/DataConsumerHandleUtil.h" 5 #include "modules/fetch/DataConsumerHandleUtil.h"
6 6
7 #include "platform/blob/BlobData.h" 7 #include "platform/blob/BlobData.h"
8 #include "public/platform/Platform.h" 8 #include "public/platform/Platform.h"
9 #include "public/platform/WebTaskRunner.h" 9 #include "public/platform/WebTaskRunner.h"
10 #include "public/platform/WebThread.h" 10 #include "public/platform/WebThread.h"
(...skipping 16 matching lines...) Expand all
27 { 27 {
28 *available = 0; 28 *available = 0;
29 *buffer = nullptr; 29 *buffer = nullptr;
30 return ShouldWait; 30 return ShouldWait;
31 } 31 }
32 Result endRead(size_t) override 32 Result endRead(size_t) override
33 { 33 {
34 return UnexpectedError; 34 return UnexpectedError;
35 } 35 }
36 }; 36 };
37 Reader* obtainReaderInternal(Client*) override { return new ReaderImpl; } 37 std::unique_ptr<Reader> obtainReader(Client*) override { return WTF::wrapUni que(new ReaderImpl); }
38 38
39 const char* debugName() const override { return "WaitingHandle"; } 39 const char* debugName() const override { return "WaitingHandle"; }
40 }; 40 };
41 41
42 class RepeatingReader final : public WebDataConsumerHandle::Reader { 42 class RepeatingReader final : public WebDataConsumerHandle::Reader {
43 public: 43 public:
44 explicit RepeatingReader(Result result, WebDataConsumerHandle::Client* clien t) : m_result(result), m_notifier(client) { } 44 explicit RepeatingReader(Result result, WebDataConsumerHandle::Client* clien t) : m_result(result), m_notifier(client) { }
45 45
46 private: 46 private:
47 Result beginRead(const void** buffer, WebDataConsumerHandle::Flags, size_t * available) override 47 Result beginRead(const void** buffer, WebDataConsumerHandle::Flags, size_t * available) override
48 { 48 {
49 *available = 0; 49 *available = 0;
50 *buffer = nullptr; 50 *buffer = nullptr;
51 return m_result; 51 return m_result;
52 } 52 }
53 Result endRead(size_t) override 53 Result endRead(size_t) override
54 { 54 {
55 return WebDataConsumerHandle::UnexpectedError; 55 return WebDataConsumerHandle::UnexpectedError;
56 } 56 }
57 57
58 Result m_result; 58 Result m_result;
59 NotifyOnReaderCreationHelper m_notifier; 59 NotifyOnReaderCreationHelper m_notifier;
60 }; 60 };
61 61
62 class DoneHandle final : public WebDataConsumerHandle { 62 class DoneHandle final : public WebDataConsumerHandle {
63 private: 63 private:
64 Reader* obtainReaderInternal(Client* client) override { return new Repeating Reader(Done, client); } 64 std::unique_ptr<Reader> obtainReader(Client* client) override { return WTF:: wrapUnique(new RepeatingReader(Done, client)); }
65 const char* debugName() const override { return "DoneHandle"; } 65 const char* debugName() const override { return "DoneHandle"; }
66 }; 66 };
67 67
68 class UnexpectedErrorHandle final : public WebDataConsumerHandle { 68 class UnexpectedErrorHandle final : public WebDataConsumerHandle {
69 private: 69 private:
70 Reader* obtainReaderInternal(Client* client) override { return new Repeating Reader(UnexpectedError, client); } 70 std::unique_ptr<Reader> obtainReader(Client* client) override { return WTF:: wrapUnique(new RepeatingReader(UnexpectedError, client)); }
71 const char* debugName() const override { return "UnexpectedErrorHandle"; } 71 const char* debugName() const override { return "UnexpectedErrorHandle"; }
72 }; 72 };
73 73
74 class WebToFetchDataConsumerHandleAdapter : public FetchDataConsumerHandle { 74 class WebToFetchDataConsumerHandleAdapter : public FetchDataConsumerHandle {
75 public: 75 public:
76 WebToFetchDataConsumerHandleAdapter(std::unique_ptr<WebDataConsumerHandle> h andle) : m_handle(std::move(handle)) { } 76 WebToFetchDataConsumerHandleAdapter(std::unique_ptr<WebDataConsumerHandle> h andle) : m_handle(std::move(handle)) { }
77 private: 77 private:
78 class ReaderImpl final : public FetchDataConsumerHandle::Reader { 78 class ReaderImpl final : public FetchDataConsumerHandle::Reader {
79 public: 79 public:
80 ReaderImpl(std::unique_ptr<WebDataConsumerHandle::Reader> reader) : m_re ader(std::move(reader)) { } 80 ReaderImpl(std::unique_ptr<WebDataConsumerHandle::Reader> reader) : m_re ader(std::move(reader)) { }
81 Result read(void* data, size_t size, Flags flags, size_t* readSize) over ride 81 Result read(void* data, size_t size, Flags flags, size_t* readSize) over ride
82 { 82 {
83 return m_reader->read(data, size, flags, readSize); 83 return m_reader->read(data, size, flags, readSize);
84 } 84 }
85 85
86 Result beginRead(const void** buffer, Flags flags, size_t* available) ov erride 86 Result beginRead(const void** buffer, Flags flags, size_t* available) ov erride
87 { 87 {
88 return m_reader->beginRead(buffer, flags, available); 88 return m_reader->beginRead(buffer, flags, available);
89 } 89 }
90 Result endRead(size_t readSize) override 90 Result endRead(size_t readSize) override
91 { 91 {
92 return m_reader->endRead(readSize); 92 return m_reader->endRead(readSize);
93 } 93 }
94 private: 94 private:
95 std::unique_ptr<WebDataConsumerHandle::Reader> m_reader; 95 std::unique_ptr<WebDataConsumerHandle::Reader> m_reader;
96 }; 96 };
97 97
98 Reader* obtainReaderInternal(Client* client) override { return new ReaderImp l(m_handle->obtainReader(client)); } 98 std::unique_ptr<Reader> obtainFetchDataReader(Client* client) override
99 {
100 return WTF::wrapUnique(new ReaderImpl(m_handle->obtainReader(client)));
101 }
99 102
100 const char* debugName() const override { return m_handle->debugName(); } 103 const char* debugName() const override { return m_handle->debugName(); }
101 104
102 std::unique_ptr<WebDataConsumerHandle> m_handle; 105 std::unique_ptr<WebDataConsumerHandle> m_handle;
103 }; 106 };
104 107
105 } // namespace 108 } // namespace
106 109
107 std::unique_ptr<WebDataConsumerHandle> createWaitingDataConsumerHandle() 110 std::unique_ptr<WebDataConsumerHandle> createWaitingDataConsumerHandle()
108 { 111 {
(...skipping 30 matching lines...) Expand all
139 // |client| dereference is safe here because: 142 // |client| dereference is safe here because:
140 // - |this| is owned by a reader, 143 // - |this| is owned by a reader,
141 // so the reader outlives |this|, and 144 // so the reader outlives |this|, and
142 // - |client| is the client of the reader, so |client| outlives the reader 145 // - |client| is the client of the reader, so |client| outlives the reader
143 // (guaranteed by the user of the reader), 146 // (guaranteed by the user of the reader),
144 // and therefore |client| outlives |this|. 147 // and therefore |client| outlives |this|.
145 client->didGetReadable(); 148 client->didGetReadable();
146 } 149 }
147 150
148 } // namespace blink 151 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698