Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.h

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock_cxx11
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ReadableStreamDataConsumerHandle_h 5 #ifndef ReadableStreamDataConsumerHandle_h
6 #define ReadableStreamDataConsumerHandle_h 6 #define ReadableStreamDataConsumerHandle_h
7 7
8 #include "bindings/core/v8/ScriptValue.h" 8 #include "bindings/core/v8/ScriptValue.h"
9 #include "modules/ModulesExport.h" 9 #include "modules/ModulesExport.h"
10 #include "modules/fetch/FetchDataConsumerHandle.h" 10 #include "modules/fetch/FetchDataConsumerHandle.h"
(...skipping 18 matching lines...) Expand all
29 // WHICH IT IS CREATED. FIX THIS. 29 // WHICH IT IS CREATED. FIX THIS.
30 class MODULES_EXPORT ReadableStreamDataConsumerHandle final : public FetchDataCo nsumerHandle { 30 class MODULES_EXPORT ReadableStreamDataConsumerHandle final : public FetchDataCo nsumerHandle {
31 WTF_MAKE_NONCOPYABLE(ReadableStreamDataConsumerHandle); 31 WTF_MAKE_NONCOPYABLE(ReadableStreamDataConsumerHandle);
32 public: 32 public:
33 static std::unique_ptr<ReadableStreamDataConsumerHandle> create(ScriptState* scriptState, ScriptValue streamReader) 33 static std::unique_ptr<ReadableStreamDataConsumerHandle> create(ScriptState* scriptState, ScriptValue streamReader)
34 { 34 {
35 return wrapUnique(new ReadableStreamDataConsumerHandle(scriptState, stre amReader)); 35 return wrapUnique(new ReadableStreamDataConsumerHandle(scriptState, stre amReader));
36 } 36 }
37 ~ReadableStreamDataConsumerHandle() override; 37 ~ReadableStreamDataConsumerHandle() override;
38 38
39 std::unique_ptr<Reader> obtainFetchDataReader(Client*) override;
40
39 private: 41 private:
40 class ReadingContext; 42 class ReadingContext;
41 ReadableStreamDataConsumerHandle(ScriptState*, ScriptValue streamReader); 43 ReadableStreamDataConsumerHandle(ScriptState*, ScriptValue streamReader);
42 Reader* obtainReaderInternal(Client*) override;
43 const char* debugName() const override { return "ReadableStreamDataConsumerH andle"; } 44 const char* debugName() const override { return "ReadableStreamDataConsumerH andle"; }
44 45
45 RefPtr<ReadingContext> m_readingContext; 46 RefPtr<ReadingContext> m_readingContext;
46 }; 47 };
47 48
48 } // namespace blink 49 } // namespace blink
49 50
50 #endif // ReadableStreamDataConsumerHandle_h 51 #endif // ReadableStreamDataConsumerHandle_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698