content/child/web_data_consumer_handle_impl_unittest.cc - Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/web_data_consumer_handle_impl_unittest.cc

Issue 2172183003: Return unique_ptr<WebDataConsumerHandle::Reader> directly from obtainReader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gmock_cxx11

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/web_data_consumer_handle_impl.cc ('k') | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/web_data_consumer_handle_impl_unittest.cc

diff --git a/content/child/web_data_consumer_handle_impl_unittest.cc b/content/child/web_data_consumer_handle_impl_unittest.cc

index 66015fb65d51c695065252051e221f197043b44b..7ad46d7f9b7257c791e8eed31ae81c40186cba0b 100644

--- a/content/child/web_data_consumer_handle_impl_unittest.cc

+++ b/content/child/web_data_consumer_handle_impl_unittest.cc

@@ -79,7 +79,7 @@ class ReadDataOperation : public ReadDataOperationBase {

void ReadData() {

if (!client_) {

client_.reset(new ClientImpl(this));

- reader_ = handle_->ObtainReader(client_.get());

+ reader_ = handle_->obtainReader(client_.get());

}

Result rv = kOk;

@@ -137,7 +137,7 @@ class TwoPhaseReadDataOperation : public ReadDataOperationBase {

void ReadData() {

if (!client_) {

client_.reset(new ClientImpl(this));

- reader_ = handle_->ObtainReader(client_.get());

+ reader_ = handle_->obtainReader(client_.get());

}

Result rv;