Remove PasswordForm::ssl_valid

Remove PasswordForm::ssl_valid

The ssl_valid attribute no longer contains useful data as it is trivially
derivable from origin for sites saved after https://crrev.com/276298. The
discussion on http://crbug.com/413020 concluded that it is OK to ignore that
argument also for older credentials and treat all passwords as if ssl_valid
were true. This CL implements that decision.

BUG=413020
Committed: https://crrev.com/61f90bf18152e77deb2179c66ccbb06456080a38
Cr-Commit-Position: refs/heads/master@{#405467}

[vabr (Chromium), 2016-07-13 12:28:55]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 12:29:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-07-13 12:29:44]

vabr@chromium.org changed reviewers:
+ dvadym@chromium.org

[vabr (Chromium), 2016-07-13 12:29:45]

Hi Vadym,

Could you please review this before I add OWNERS (in particular security and
sync)?

Thanks!
Vaclav

[commit-bot: I haz the power, 2016-07-13 12:37:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 12:37:49]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vabr (Chromium), 2016-07-13 13:06:45]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 13:07:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 13:15:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 13:15:29]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vabr (Chromium), 2016-07-13 14:04:34]

Description was changed from

==========
Remove PasswordForm::ssl_valid

This is still a WIP.
COMMIT=false

The ssl_valid attribute no longer contains useful data as it is trivially
derivable from origin for sites saved after https://crrev.com/276298. The
discussion on http://crbug.com/413020 concluded that it is OK to ignore that
argument also for older credentials and treat all passwords as if ssl_valid
were true. This CL implements that decision.

BUG=413020
==========

to

==========
Remove PasswordForm::ssl_valid

The ssl_valid attribute no longer contains useful data as it is trivially
derivable from origin for sites saved after https://crrev.com/276298. The
discussion on http://crbug.com/413020 concluded that it is OK to ignore that
argument also for older credentials and treat all passwords as if ssl_valid
were true. This CL implements that decision.

BUG=413020
==========

[vabr (Chromium), 2016-07-13 20:04:32]

vabr@chromium.org changed reviewers:
+ anthonyvd@chromium.org, isherman@chromium.org, mkwst@chromium.org,
stanisc@chromium.org

[vabr (Chromium), 2016-07-13 20:04:33]

Adding some more reviewers. Please review

mkwst: components/autofill/content/public/cpp/*.

stanisc: sync/*. Does the proto need to be update on the server side as well?

isherman: tools/metrics/histograms/histograms.xml and
chrome/utility/importer/ie_importer_win.cc

anthonyvd: chrome/browser/profiles/profile_manager_browsertest.cc

Thank you all!
Vaclav

[anthonyvd, 2016-07-13 20:08:46]

chrome/browser/profiles/profile_manager_browsertest.cc lgtm

[Ilya Sherman, 2016-07-13 21:03:23]

importer and histograms.xml lgtm

[stanisc, 2016-07-13 21:10:02]

sync lgtm

[Mike West, 2016-07-14 05:25:56]

Dropping the flag from IPC LGTM.

[vabr (Chromium), 2016-07-14 08:20:02]

Thanks all for review so far!

Vadym -- just a heads-up: because I'm currently upstreaming password manager
unittests from iOS (https://codereview.chromium.org/2152593002/), I'll rebase
this CL on that upstreaming, and do one necessary adjustment of the new unittest
inside //ios (which was planned downstream before). This change will be isolated
and not touching anything already existing in this CL. I'll ping you when I
upload the new patch, but you can continue reviewing in the meantime, if you
want to.

Cheers,
Vaclav

[vabr (Chromium), 2016-07-14 08:32:05]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 08:32:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 08:43:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 08:43:08]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vabr (Chromium), 2016-07-14 09:23:02]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 09:23:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 10:14:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 10:14:21]

Dry run: This issue passed the CQ dry run.

[dvadym, 2016-07-14 10:21:41]

LGTM, thanks for removing ssl_valid field and simplification of our codebase

[vabr (Chromium), 2016-07-14 10:26:02]

On 2016/07/14 10:21:41, dvadym wrote:
> LGTM, thanks for removing ssl_valid field and simplification of our codebase

Thanks!

I am just finishing the downstream preparations, and as soon as they land will
send this to the CQ.

Cheers,
Vaclav

[vabr (Chromium), 2016-07-14 10:43:14]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-07-14 10:43:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
isherman@chromium.org, anthonyvd@chromium.org, stanisc@chromium.org
Link to the patchset: https://codereview.chromium.org/2127533003/#ps320001
(title: "Adjust //ios")

[commit-bot: I haz the power, 2016-07-14 10:43:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 10:49:01]

Description was changed from

==========
Remove PasswordForm::ssl_valid

The ssl_valid attribute no longer contains useful data as it is trivially
derivable from origin for sites saved after https://crrev.com/276298. The
discussion on http://crbug.com/413020 concluded that it is OK to ignore that
argument also for older credentials and treat all passwords as if ssl_valid
were true. This CL implements that decision.

BUG=413020
==========

to

==========
Remove PasswordForm::ssl_valid

The ssl_valid attribute no longer contains useful data as it is trivially
derivable from origin for sites saved after https://crrev.com/276298. The
discussion on http://crbug.com/413020 concluded that it is OK to ignore that
argument also for older credentials and treat all passwords as if ssl_valid
were true. This CL implements that decision.

BUG=413020
==========

[commit-bot: I haz the power, 2016-07-14 10:49:03]

Committed patchset #17 (id:320001)

[commit-bot: I haz the power, 2016-07-14 10:51:01]

Description was changed from

==========
Remove PasswordForm::ssl_valid

The ssl_valid attribute no longer contains useful data as it is trivially
derivable from origin for sites saved after https://crrev.com/276298. The
discussion on http://crbug.com/413020 concluded that it is OK to ignore that
argument also for older credentials and treat all passwords as if ssl_valid
were true. This CL implements that decision.

BUG=413020
==========

to

==========
Remove PasswordForm::ssl_valid

The ssl_valid attribute no longer contains useful data as it is trivially
derivable from origin for sites saved after https://crrev.com/276298. The
discussion on http://crbug.com/413020 concluded that it is OK to ignore that
argument also for older credentials and treat all passwords as if ssl_valid
were true. This CL implements that decision.

BUG=413020

Committed: https://crrev.com/61f90bf18152e77deb2179c66ccbb06456080a38
Cr-Commit-Position: refs/heads/master@{#405467}
==========

[commit-bot: I haz the power, 2016-07-14 10:51:03]

Patchset 17 (id:??) landed as
https://crrev.com/61f90bf18152e77deb2179c66ccbb06456080a38
Cr-Commit-Position: refs/heads/master@{#405467}