components/password_manager/core/browser/password_syncable_service_unittest.cc - Issue 2127533003: Remove PasswordForm::ssl_valid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_syncable_service_unittest.cc

Issue 2127533003: Remove PasswordForm::ssl_valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust //ios Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_syncable_service.cc ('k') | components/test/data/password_manager/login_db_v18.sql » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_syncable_service_unittest.cc

diff --git a/components/password_manager/core/browser/password_syncable_service_unittest.cc b/components/password_manager/core/browser/password_syncable_service_unittest.cc

index df7f280a3c2a5aad5153f5f529f42a9240ad17cf..15745fc88deaa1622e19fce53d902ea3a94bb22c 100644

--- a/components/password_manager/core/browser/password_syncable_service_unittest.cc

+++ b/components/password_manager/core/browser/password_syncable_service_unittest.cc

@@ -88,7 +88,6 @@ MATCHER_P(PasswordIs, form, "") {

actual_password.password_element() &&

expected_password.username_value() == actual_password.username_value() &&

expected_password.password_value() == actual_password.password_value() &&

- expected_password.ssl_valid() == actual_password.ssl_valid() &&

expected_password.preferred() == actual_password.preferred() &&

expected_password.date_created() == actual_password.date_created() &&

expected_password.blacklisted() == actual_password.blacklisted() &&

@@ -630,8 +629,6 @@ TEST_F(PasswordSyncableServiceTest, SerializeEmptyPasswordForm) {

EXPECT_EQ("", specifics.password_element());

EXPECT_TRUE(specifics.has_password_value());

EXPECT_EQ("", specifics.password_value());

- EXPECT_TRUE(specifics.has_ssl_valid());

- EXPECT_FALSE(specifics.ssl_valid());

EXPECT_TRUE(specifics.has_preferred());

EXPECT_FALSE(specifics.preferred());

EXPECT_TRUE(specifics.has_date_created());

@@ -662,7 +659,6 @@ TEST_F(PasswordSyncableServiceTest, SerializeNonEmptyPasswordForm) {

form.username_value = base::ASCIIToUTF16("god@google.com");

form.password_element = base::ASCIIToUTF16("password_element");

form.password_value = base::ASCIIToUTF16("!@#$%^&*()");

- form.ssl_valid = true;

form.preferred = true;

form.date_created = base::Time::FromInternalValue(100);

form.blacklisted_by_user = true;

@@ -690,8 +686,6 @@ TEST_F(PasswordSyncableServiceTest, SerializeNonEmptyPasswordForm) {

EXPECT_EQ("password_element", specifics.password_element());

EXPECT_TRUE(specifics.has_password_value());

EXPECT_EQ("!@#$%^&*()", specifics.password_value());

- EXPECT_TRUE(specifics.has_ssl_valid());

- EXPECT_TRUE(specifics.ssl_valid());

EXPECT_TRUE(specifics.has_preferred());

EXPECT_TRUE(specifics.preferred());

EXPECT_TRUE(specifics.has_date_created());