Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Side by Side Diff: components/autofill/core/common/password_form.h

Issue 2127533003: Remove PasswordForm::ssl_valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust //ios Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 base::string16 new_password_value; 169 base::string16 new_password_value;
170 170
171 // Whether the password value is the same as specified in the "value" 171 // Whether the password value is the same as specified in the "value"
172 // attribute of the input element. Only used in the renderer. 172 // attribute of the input element. Only used in the renderer.
173 bool new_password_value_is_default; 173 bool new_password_value_is_default;
174 174
175 // Whether the |new_password_element| has an autocomplete=new-password 175 // Whether the |new_password_element| has an autocomplete=new-password
176 // attribute. This is only used in parsed HTML forms. 176 // attribute. This is only used in parsed HTML forms.
177 bool new_password_marked_by_site; 177 bool new_password_marked_by_site;
178 178
179 // Whether or not this login was saved under an HTTPS session with a valid
180 // SSL cert. We will never match or autofill a PasswordForm where
181 // ssl_valid == true with a PasswordForm where ssl_valid == false. This means
182 // passwords saved under HTTPS will never get autofilled onto an HTTP page.
183 // When importing, this should be set to true if the page URL is HTTPS, thus
184 // giving it "the benefit of the doubt" that the SSL cert was valid when it
185 // was saved. Default to false.
186 bool ssl_valid;
187
188 // True if this PasswordForm represents the last username/password login the 179 // True if this PasswordForm represents the last username/password login the
189 // user selected to log in to the site. If there is only one saved entry for 180 // user selected to log in to the site. If there is only one saved entry for
190 // the site, this will always be true, but when there are multiple entries 181 // the site, this will always be true, but when there are multiple entries
191 // the PasswordManager ensures that only one of them has a preferred bit set 182 // the PasswordManager ensures that only one of them has a preferred bit set
192 // to true. Default to false. 183 // to true. Default to false.
193 // 184 //
194 // When parsing an HTML form, this is not used. 185 // When parsing an HTML form, this is not used.
195 bool preferred; 186 bool preferred;
196 187
197 // When the login was saved (by chrome). 188 // When the login was saved (by chrome).
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 using ConstPasswordFormMap = std::map<base::string16, const PasswordForm*>; 303 using ConstPasswordFormMap = std::map<base::string16, const PasswordForm*>;
313 304
314 // For testing. 305 // For testing.
315 std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout); 306 std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout);
316 std::ostream& operator<<(std::ostream& os, const PasswordForm& form); 307 std::ostream& operator<<(std::ostream& os, const PasswordForm& form);
317 std::ostream& operator<<(std::ostream& os, PasswordForm* form); 308 std::ostream& operator<<(std::ostream& os, PasswordForm* form);
318 309
319 } // namespace autofill 310 } // namespace autofill
320 311
321 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 312 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698