components/password_manager/core/browser/password_syncable_service.cc - Issue 2127533003: Remove PasswordForm::ssl_valid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_syncable_service.cc

Issue 2127533003: Remove PasswordForm::ssl_valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust //ios Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store_unittest.cc ('k') | components/password_manager/core/browser/password_syncable_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_syncable_service.cc

diff --git a/components/password_manager/core/browser/password_syncable_service.cc b/components/password_manager/core/browser/password_syncable_service.cc

index 5eda9433b430a9cf49fe86c6def67331464e60ca..b7d214ac13523d68d9174c1269ad4032ad3df23c 100644

--- a/components/password_manager/core/browser/password_syncable_service.cc

+++ b/components/password_manager/core/browser/password_syncable_service.cc

@@ -50,7 +50,6 @@ bool AreLocalAndSyncPasswordsEqual(

password_specifics.username_value() &&

base::UTF16ToUTF8(password_form.password_value) ==

password_specifics.password_value() &&

- password_form.ssl_valid == password_specifics.ssl_valid() &&

password_form.preferred == password_specifics.preferred() &&

password_form.date_created.ToInternalValue() ==

password_specifics.date_created() &&

@@ -454,7 +453,6 @@ syncer::SyncData SyncDataFromPassword(

CopyStringField(password_element);

CopyStringField(username_value);

CopyStringField(password_value);

- CopyField(ssl_valid);

CopyField(preferred);

password_specifics->set_date_created(

password_form.date_created.ToInternalValue());

@@ -488,7 +486,6 @@ autofill::PasswordForm PasswordFromSpecifics(

base::UTF8ToUTF16(password.password_element());

new_password.username_value = base::UTF8ToUTF16(password.username_value());

new_password.password_value = base::UTF8ToUTF16(password.password_value());

- new_password.ssl_valid = password.ssl_valid();

new_password.preferred = password.preferred();

new_password.date_created =

base::Time::FromInternalValue(password.date_created());