Upstream password manager unit tests

Upstream password manager unit tests

This CL:
 (1) Made a verbatim copy of the tests from downstream, and
 (2) ran `git cl format' over them to satisfy the presubmit check.

password_controller_unittest.mm already existed upstream, but got overwritten
with the downstream version, which subsumed the already existing upstream
testcase.

BUG=514241
Committed: https://crrev.com/ab72f831555ab7c9f395a7c8f201b0b3f5c1a309
Cr-Commit-Position: refs/heads/master@{#405453}

[vabr (Chromium), 2016-07-13 21:56:58]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 21:57:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 22:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 22:06:09]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[vabr (Chromium), 2016-07-13 22:08:35]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 22:09:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-07-13 22:16:22]

vabr@chromium.org changed reviewers:
+ eugenebut@chromium.org

[vabr (Chromium), 2016-07-13 22:16:23]

Hi Eugene,

Sorry for one more, and huge, CL for review. Please note:
(1) This is not urgent (I'm OOO on Friday).
(2) While seemingly adding 6 new files, they all come from downstream. I did not
modify them beyond compulsory formatting.

Given the above, would you be willing to have a look? Alternatively, could you
please just review the changed DEPS (and I can find a reviewer for the rest in
my team)? Please let me know what you prefer.

Thanks!
Vaclav

[commit-bot: I haz the power, 2016-07-13 22:24:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 22:24:34]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Eugene But (OOO till 7-30), 2016-07-13 22:30:31]

lgtm I understand that you just upstreaming existing code, but would be great if
you could do some small cleanup according to suggestions.

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/credential_manager_js_unittest.mm (right):

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/credential_manager_js_unittest.mm:8: #include
"base/mac/scoped_nsobject.h"
s/include/import

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_controller_js_unittest.mm (right):

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_js_unittest.mm:64:
TEST_F(PasswordControllerJsTest,
If you understand the purpose if these tests, could you please add comments.

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm
(right):

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm:7:
#include "base/mac/scoped_nsobject.h"
s/include/import

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm:12:
#include "ios/web/public/test/test_web_state.h"
s/include/import

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm:62:
TEST_F(PasswordControllerOffTheRecordTest, PasswordGenerationDisabled) {
If you understand the purpose if these tests, could you please add comments.

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_controller_unittest.mm (right):

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_unittest.mm:264:
TEST_F(PasswordControllerTest, PopulatePasswordFormWithDictionary) {
If you understand the purpose if these tests, could you please add comments.

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_generation_agent_unittest.mm (right):

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_generation_agent_unittest.mm:12: #include
"base/mac/scoped_nsobject.h"
s/include/import

[vabr (Chromium), 2016-07-14 07:36:31]

Thank you, Eugene, for the good comments and an amazingly quick review!

I had no troubles addressing your comments, so will be landing soon.

Cheers!
Vaclav

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/credential_manager_js_unittest.mm (right):

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/credential_manager_js_unittest.mm:8: #include
"base/mac/scoped_nsobject.h"
On 2016/07/13 22:30:31, Eugene But wrote:
> s/include/import

Done.

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_controller_js_unittest.mm (right):

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_js_unittest.mm:64:
TEST_F(PasswordControllerJsTest,
On 2016/07/13 22:30:31, Eugene But wrote:
> If you understand the purpose if these tests, could you please add comments.

Done, this was a good exercise. :)

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm
(right):

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm:7:
#include "base/mac/scoped_nsobject.h"
On 2016/07/13 22:30:31, Eugene But wrote:
> s/include/import

Done.

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm:12:
#include "ios/web/public/test/test_web_state.h"
On 2016/07/13 22:30:31, Eugene But wrote:
> s/include/import

Done.

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm:62:
TEST_F(PasswordControllerOffTheRecordTest, PasswordGenerationDisabled) {
On 2016/07/13 22:30:31, Eugene But wrote:
> If you understand the purpose if these tests, could you please add comments.

Done.

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_controller_unittest.mm (right):

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller_unittest.mm:264:
TEST_F(PasswordControllerTest, PopulatePasswordFormWithDictionary) {
On 2016/07/13 22:30:31, Eugene But wrote:
> If you understand the purpose if these tests, could you please add comments.

Done.

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_generation_agent_unittest.mm (right):

https://codereview.chromium.org/2152593002/diff/40001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_generation_agent_unittest.mm:12: #include
"base/mac/scoped_nsobject.h"
On 2016/07/13 22:30:31, Eugene But wrote:
> s/include/import

Done.

[vabr (Chromium), 2016-07-14 07:36:41]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-07-14 07:36:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2152593002/#ps60001
(title: "Review comments")

[commit-bot: I haz the power, 2016-07-14 07:36:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 07:47:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 07:47:04]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[vabr (Chromium), 2016-07-14 08:12:15]

On 2016/07/14 07:47:04, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   ios-device on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

The failures seem like a missing dependency in GYP. I added it (it was in GN
already), and will try the CQ again.

Cheers,
Vaclav

[vabr (Chromium), 2016-07-14 08:12:21]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-07-14 08:12:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2152593002/#ps80001
(title: "Fix GYP")

[commit-bot: I haz the power, 2016-07-14 08:12:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 09:20:21]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-14 09:22:28]

Description was changed from

==========
Upstream password manager unit tests

This CL:
 (1) Made a verbatim copy of the tests from downstream, and
 (2) ran `git cl format' over them to satisfy the presubmit check.

password_controller_unittest.mm already existed upstream, but got overwritten
with the downstream version, which subsumed the already existing upstream
testcase.

BUG=514241
==========

to

==========
Upstream password manager unit tests

This CL:
 (1) Made a verbatim copy of the tests from downstream, and
 (2) ran `git cl format' over them to satisfy the presubmit check.

password_controller_unittest.mm already existed upstream, but got overwritten
with the downstream version, which subsumed the already existing upstream
testcase.

BUG=514241

Committed: https://crrev.com/ab72f831555ab7c9f395a7c8f201b0b3f5c1a309
Cr-Commit-Position: refs/heads/master@{#405453}
==========

[commit-bot: I haz the power, 2016-07-14 09:22:29]

Patchset 5 (id:??) landed as
https://crrev.com/ab72f831555ab7c9f395a7c8f201b0b3f5c1a309
Cr-Commit-Position: refs/heads/master@{#405453}