Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: components/autofill/core/common/password_form.cc

Issue 2127533003: Remove PasswordForm::ssl_valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust //ios Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <ostream> 5 #include <ostream>
6 #include <sstream> 6 #include <sstream>
7 7
8 #include "base/json/json_writer.h" 8 #include "base/json/json_writer.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 27 matching lines...) Expand all
38 target->SetString("new_password_value", form.new_password_value); 38 target->SetString("new_password_value", form.new_password_value);
39 target->SetBoolean("new_password_value_is_default", 39 target->SetBoolean("new_password_value_is_default",
40 form.new_password_value_is_default); 40 form.new_password_value_is_default);
41 target->SetBoolean("new_password_marked_by_site", 41 target->SetBoolean("new_password_marked_by_site",
42 form.new_password_marked_by_site); 42 form.new_password_marked_by_site);
43 target->SetString("other_possible_usernames", 43 target->SetString("other_possible_usernames",
44 base::JoinString(form.other_possible_usernames, 44 base::JoinString(form.other_possible_usernames,
45 base::ASCIIToUTF16("|"))); 45 base::ASCIIToUTF16("|")));
46 target->SetBoolean("blacklisted", form.blacklisted_by_user); 46 target->SetBoolean("blacklisted", form.blacklisted_by_user);
47 target->SetBoolean("preferred", form.preferred); 47 target->SetBoolean("preferred", form.preferred);
48 target->SetBoolean("ssl_valid", form.ssl_valid);
49 target->SetDouble("date_created", form.date_created.ToDoubleT()); 48 target->SetDouble("date_created", form.date_created.ToDoubleT());
50 target->SetDouble("date_synced", form.date_synced.ToDoubleT()); 49 target->SetDouble("date_synced", form.date_synced.ToDoubleT());
51 target->SetInteger("type", form.type); 50 target->SetInteger("type", form.type);
52 target->SetInteger("times_used", form.times_used); 51 target->SetInteger("times_used", form.times_used);
53 std::ostringstream form_data_string_stream; 52 std::ostringstream form_data_string_stream;
54 form_data_string_stream << form.form_data; 53 form_data_string_stream << form.form_data;
55 target->SetString("form_data", form_data_string_stream.str()); 54 target->SetString("form_data", form_data_string_stream.str());
56 target->SetInteger("generation_upload_status", form.generation_upload_status); 55 target->SetInteger("generation_upload_status", form.generation_upload_status);
57 target->SetString("display_name", form.display_name); 56 target->SetString("display_name", form.display_name);
58 target->SetString("icon_url", form.icon_url.possibly_invalid_spec()); 57 target->SetString("icon_url", form.icon_url.possibly_invalid_spec());
(...skipping 10 matching lines...) Expand all
69 } 68 }
70 69
71 } // namespace 70 } // namespace
72 71
73 PasswordForm::PasswordForm() 72 PasswordForm::PasswordForm()
74 : scheme(SCHEME_HTML), 73 : scheme(SCHEME_HTML),
75 username_marked_by_site(false), 74 username_marked_by_site(false),
76 password_value_is_default(false), 75 password_value_is_default(false),
77 new_password_value_is_default(false), 76 new_password_value_is_default(false),
78 new_password_marked_by_site(false), 77 new_password_marked_by_site(false),
79 ssl_valid(false),
80 preferred(false), 78 preferred(false),
81 blacklisted_by_user(false), 79 blacklisted_by_user(false),
82 type(TYPE_MANUAL), 80 type(TYPE_MANUAL),
83 times_used(0), 81 times_used(0),
84 generation_upload_status(NO_SIGNAL_SENT), 82 generation_upload_status(NO_SIGNAL_SENT),
85 skip_zero_click(true), 83 skip_zero_click(true),
86 layout(Layout::LAYOUT_OTHER), 84 layout(Layout::LAYOUT_OTHER),
87 was_parsed_using_autofill_predictions(false), 85 was_parsed_using_autofill_predictions(false),
88 is_public_suffix_match(false), 86 is_public_suffix_match(false),
89 is_affiliation_based_match(false), 87 is_affiliation_based_match(false),
(...skipping 19 matching lines...) Expand all
109 submit_element == form.submit_element && 107 submit_element == form.submit_element &&
110 username_element == form.username_element && 108 username_element == form.username_element &&
111 username_marked_by_site == form.username_marked_by_site && 109 username_marked_by_site == form.username_marked_by_site &&
112 username_value == form.username_value && 110 username_value == form.username_value &&
113 other_possible_usernames == form.other_possible_usernames && 111 other_possible_usernames == form.other_possible_usernames &&
114 password_element == form.password_element && 112 password_element == form.password_element &&
115 password_value == form.password_value && 113 password_value == form.password_value &&
116 new_password_element == form.new_password_element && 114 new_password_element == form.new_password_element &&
117 new_password_marked_by_site == form.new_password_marked_by_site && 115 new_password_marked_by_site == form.new_password_marked_by_site &&
118 new_password_value == form.new_password_value && 116 new_password_value == form.new_password_value &&
119 ssl_valid == form.ssl_valid && preferred == form.preferred && 117 preferred == form.preferred && date_created == form.date_created &&
120 date_created == form.date_created && date_synced == form.date_synced && 118 date_synced == form.date_synced &&
121 blacklisted_by_user == form.blacklisted_by_user && type == form.type && 119 blacklisted_by_user == form.blacklisted_by_user && type == form.type &&
122 times_used == form.times_used && 120 times_used == form.times_used &&
123 form_data.SameFormAs(form.form_data) && 121 form_data.SameFormAs(form.form_data) &&
124 generation_upload_status == form.generation_upload_status && 122 generation_upload_status == form.generation_upload_status &&
125 display_name == form.display_name && icon_url == form.icon_url && 123 display_name == form.display_name && icon_url == form.icon_url &&
126 // We compare the serialization of the origins here, as we want unique 124 // We compare the serialization of the origins here, as we want unique
127 // origins to compare as '=='. 125 // origins to compare as '=='.
128 federation_origin.Serialize() == form.federation_origin.Serialize() && 126 federation_origin.Serialize() == form.federation_origin.Serialize() &&
129 skip_zero_click == form.skip_zero_click && layout == form.layout && 127 skip_zero_click == form.skip_zero_click && layout == form.layout &&
130 was_parsed_using_autofill_predictions == 128 was_parsed_using_autofill_predictions ==
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 form_json, base::JSONWriter::OPTIONS_PRETTY_PRINT, &form_as_string); 201 form_json, base::JSONWriter::OPTIONS_PRETTY_PRINT, &form_as_string);
204 base::TrimWhitespaceASCII(form_as_string, base::TRIM_ALL, &form_as_string); 202 base::TrimWhitespaceASCII(form_as_string, base::TRIM_ALL, &form_as_string);
205 return os << "PasswordForm(" << form_as_string << ")"; 203 return os << "PasswordForm(" << form_as_string << ")";
206 } 204 }
207 205
208 std::ostream& operator<<(std::ostream& os, PasswordForm* form) { 206 std::ostream& operator<<(std::ostream& os, PasswordForm* form) {
209 return os << "&" << *form; 207 return os << "&" << *form;
210 } 208 }
211 209
212 } // namespace autofill 210 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/core/common/password_form.h ('k') | components/autofill/core/common/password_form_fill_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698