ios/chrome/browser/passwords/credential_manager.mm - Issue 2127533003: Remove PasswordForm::ssl_valid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/passwords/credential_manager.mm

Issue 2127533003: Remove PasswordForm::ssl_valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust //ios Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/passwords/credential_manager.mm

diff --git a/ios/chrome/browser/passwords/credential_manager.mm b/ios/chrome/browser/passwords/credential_manager.mm

index 3ad9eb29c611f7a0fd0baaa41095190ce5c0d818..8c8779f4855d3a3e730d593e59ca12d2e1c80c67 100644

--- a/ios/chrome/browser/passwords/credential_manager.mm

+++ b/ios/chrome/browser/passwords/credential_manager.mm

@@ -317,8 +317,6 @@ autofill::PasswordForm CredentialManager::GetSynthesizedFormForOrigin() const {

synthetic_form.origin = web_state()->GetLastCommittedURL().GetOrigin();

synthetic_form.signon_realm = synthetic_form.origin.spec();

synthetic_form.scheme = autofill::PasswordForm::SCHEME_HTML;

- synthetic_form.ssl_valid = synthetic_form.origin.SchemeIsCryptographic() &&

- !client_->DidLastPageLoadEncounterSSLErrors();

return synthetic_form;

}