Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: components/password_manager/core/browser/affiliated_match_helper_unittest.cc

Issue 2127533003: Remove PasswordForm::ssl_valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust //ios Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/affiliated_match_helper_unittest.cc
diff --git a/components/password_manager/core/browser/affiliated_match_helper_unittest.cc b/components/password_manager/core/browser/affiliated_match_helper_unittest.cc
index 79694ffc16bdb23cc035316398e67c27b9fb2018..a8b8c9414a7405afee4fecf38288396925cfd29d 100644
--- a/components/password_manager/core/browser/affiliated_match_helper_unittest.cc
+++ b/components/password_manager/core/browser/affiliated_match_helper_unittest.cc
@@ -144,7 +144,6 @@ autofill::PasswordForm GetTestAndroidCredentials(const char* signon_realm) {
form.signon_realm = signon_realm;
form.username_value = base::ASCIIToUTF16(kTestUsername);
form.password_value = base::ASCIIToUTF16(kTestPassword);
- form.ssl_valid = true;
return form;
}
@@ -162,7 +161,6 @@ autofill::PasswordForm GetTestObservedWebForm(const char* signon_realm,
form.signon_realm = signon_realm;
if (origin)
form.origin = GURL(origin);
- form.ssl_valid = true;
return form;
}
@@ -380,15 +378,6 @@ TEST_F(AffiliatedMatchHelperTest,
}
TEST_F(AffiliatedMatchHelperTest,
- GetAffiliatedAndroidRealmsYieldsEmptyResultsForInsecureForms) {
- autofill::PasswordForm insecure_observed_form(
- GetTestObservedWebForm(kTestWebRealmAlpha1, nullptr));
- insecure_observed_form.ssl_valid = false;
- EXPECT_THAT(GetAffiliatedAndroidRealms(insecure_observed_form),
- testing::IsEmpty());
-}
-
-TEST_F(AffiliatedMatchHelperTest,
GetAffiliatedAndroidRealmsYieldsEmptyResultsForHTTPBasicAuthForms) {
autofill::PasswordForm http_auth_observed_form(
GetTestObservedWebForm(kTestWebRealmAlpha1, nullptr));

Powered by Google App Engine
This is Rietveld 408576698