Remove PasswordForm::ssl_valid

chrome/browser/password_manager/password_store_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_store_mac.h"
 
 #include <CoreServices/CoreServices.h>
 #include <stddef.h>
 #include <set>
 #include <string>
@@ skipping 345 matching lines @@
 
   if (extract_password_data) {
     base::UTF8ToUTF16(static_cast<const char *>(password_data), password_length,
                       &(form->password_value));
   }
 
   int port = kAnyPort;
   std::string server;
   std::string security_domain;
   std::string path;
+  bool is_secure = false;
   for (unsigned int i = 0; i < attrList->count; i++) {
     SecKeychainAttribute attr = attrList->attr[i];
     if (!attr.data) {
       continue;
     }
     switch (attr.tag) {
       case kSecAccountItemAttr:
         base::UTF8ToUTF16(static_cast<const char *>(attr.data), attr.length,
                           &(form->username_value));
         break;
       case kSecServerItemAttr:
         server.assign(static_cast<const char *>(attr.data), attr.length);
         break;
       case kSecPortItemAttr:
         port = *(static_cast<UInt32*>(attr.data));
         break;
       case kSecPathItemAttr:
         path.assign(static_cast<const char *>(attr.data), attr.length);
         break;
       case kSecProtocolItemAttr:
       {
         SecProtocolType protocol = *(static_cast<SecProtocolType*>(attr.data));
         // TODO(stuartmorgan): Handle proxy types
-        form->ssl_valid = (protocol == kSecProtocolTypeHTTPS);
+        is_secure = (protocol == kSecProtocolTypeHTTPS);
         break;
       }
       case kSecAuthenticationTypeItemAttr:
       {
         SecAuthenticationType auth_type =
             *(static_cast<SecAuthenticationType*>(attr.data));
         form->scheme = SchemeForAuthType(auth_type);
         break;
       }
       case kSecSecurityDomainItemAttr:
@@ skipping 22 matching lines @@
   if (extract_password_data && (form->password_value.empty() ||
                                 base::EqualsASCII(form->password_value, " "))) {
     form->blacklisted_by_user = true;
   }
 
   // Android facet URLs aren't parsed correctly by GURL and need to be handled
   // separately.
   if (password_manager::IsValidAndroidFacetURI(server)) {
     form->signon_realm = server;
     form->origin = GURL();
-    form->ssl_valid = true;
   } else {
-    form->origin = URLFromComponents(form->ssl_valid, server, port, path);
+    form->origin = URLFromComponents(is_secure, server, port, path);
     // TODO(stuartmorgan): Handle proxies, which need a different signon_realm
     // format.
     form->signon_realm = form->origin.GetOrigin().spec();
     if (form->scheme != PasswordForm::SCHEME_HTML) {
       form->signon_realm.append(security_domain);
     }
   }
   return true;
 }
 
@@ skipping 951 matching lines @@
   ScopedVector<PasswordForm> forms_with_keychain_entry;
   internal_keychain_helpers::GetPasswordsForForms(*keychain_, &database_forms,
                                                   &forms_with_keychain_entry);
 
   // Clean up any orphaned database entries.
   RemoveDatabaseForms(&database_forms);
 
   // Move the orphaned DB forms to the output parameter.
   AppendSecondToFirst(orphaned_forms, &database_forms);
 }