components/password_manager/core/browser/affiliated_match_helper.cc - Issue 2127533003: Remove PasswordForm::ssl_valid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/affiliated_match_helper.cc

Issue 2127533003: Remove PasswordForm::ssl_valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust //ios Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/BUILD.gn ('k') | components/password_manager/core/browser/affiliated_match_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/affiliated_match_helper.cc

diff --git a/components/password_manager/core/browser/affiliated_match_helper.cc b/components/password_manager/core/browser/affiliated_match_helper.cc

index dc56945a33c4389bce51e0bf9429ebcf9527a6cc..ee18665afdc3ee600aecedb9cf5d3b32fd313834 100644

--- a/components/password_manager/core/browser/affiliated_match_helper.cc

+++ b/components/password_manager/core/browser/affiliated_match_helper.cc

@@ -140,7 +140,7 @@ bool AffiliatedMatchHelper::IsValidAndroidCredential(

bool AffiliatedMatchHelper::IsValidWebCredential(

const autofill::PasswordForm& form) {

FacetURI facet_uri(FacetURI::FromPotentiallyInvalidSpec(form.signon_realm));

- return form.scheme == autofill::PasswordForm::SCHEME_HTML && form.ssl_valid &&

+ return form.scheme == autofill::PasswordForm::SCHEME_HTML &&

facet_uri.IsValidWebFacetURI();

}