components/password_manager/content/browser/credential_manager_impl.cc - Issue 2127533003: Remove PasswordForm::ssl_valid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_impl.cc

Issue 2127533003: Remove PasswordForm::ssl_valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust //ios Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/save_password_progress_logger.cc ('k') | components/password_manager/content/browser/credential_manager_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_impl.cc

diff --git a/components/password_manager/content/browser/credential_manager_impl.cc b/components/password_manager/content/browser/credential_manager_impl.cc

index ba0cf7dda227d84da9820bc3aaca0a94be96ac08..b303a71763078c73f699575de8ea5e44ab5cbb1e 100644

--- a/components/password_manager/content/browser/credential_manager_impl.cc

+++ b/components/password_manager/content/browser/credential_manager_impl.cc

@@ -264,8 +264,6 @@ autofill::PasswordForm CredentialManagerImpl::GetSynthesizedFormForOrigin()

synthetic_form.origin = web_contents()->GetLastCommittedURL().GetOrigin();

synthetic_form.signon_realm = synthetic_form.origin.spec();

synthetic_form.scheme = autofill::PasswordForm::SCHEME_HTML;

- synthetic_form.ssl_valid = synthetic_form.origin.SchemeIsCryptographic() &&

- !client_->DidLastPageLoadEncounterSSLErrors();

return synthetic_form;

}