Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 2127533003: Remove PasswordForm::ssl_valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust //ios Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index f018d34ad6bf8e13408ce774971bc3728eff15ce..c3f9e10d513dfbc60477d6d9960277a6f07843c6 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -52,13 +52,6 @@ namespace password_manager {
namespace {
-PasswordForm CopyAndModifySSLValidity(const PasswordForm& orig,
- bool ssl_valid) {
- PasswordForm result(orig);
- result.ssl_valid = ssl_valid;
- return result;
-}
-
// Returns true if user-typed username and password field values match with one
// of the password form within |credentials| map; otherwise false.
bool DoesUsenameAndPasswordMatchCredentials(
@@ -172,9 +165,8 @@ PasswordFormManager::PasswordFormManager(
PasswordManagerClient* client,
const base::WeakPtr<PasswordManagerDriver>& driver,
const PasswordForm& observed_form,
- bool ssl_valid,
std::unique_ptr<FormSaver> form_saver)
- : observed_form_(CopyAndModifySSLValidity(observed_form, ssl_valid)),
+ : observed_form_(observed_form),
provisionally_saved_form_(nullptr),
other_possible_username_action_(
PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES),
@@ -488,12 +480,6 @@ void PasswordFormManager::OnRequestDone(
}
// Remove credentials which need to be ignored from |logins_result|.
- if (!observed_form_.ssl_valid) {
- logins_result.erase(
- std::partition(logins_result.begin(), logins_result.end(),
- [](PasswordForm* form) { return !form->ssl_valid; }),
- logins_result.end());
- }
logins_result =
client_->GetStoreResultFilter()->FilterResults(std::move(logins_result));

Powered by Google App Engine
This is Rietveld 408576698