Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 2127533003: Remove PasswordForm::ssl_valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust //ios Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 3783547769da317a37944c33b5d95df0ecad4256..17e8d65ee9effb24f00c84e8206f0fe80dc97af5 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -229,9 +229,8 @@ void PasswordManager::SetGenerationElementAndReasonForForm(
// If there is no corresponding PasswordFormManager, we create one. This is
// not the common case, and should only happen when there is a bug in our
// ability to detect forms.
- bool ssl_valid = form.origin.SchemeIsCryptographic();
PasswordFormManager* manager = new PasswordFormManager(
- this, client_, driver->AsWeakPtr(), form, ssl_valid,
+ this, client_, driver->AsWeakPtr(), form,
base::WrapUnique(new FormSaverImpl(client_->GetPasswordStore())));
pending_login_managers_.push_back(manager);
manager->FetchDataFromPasswordStore();
@@ -342,9 +341,6 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
}
PasswordForm provisionally_saved_form(form);
- provisionally_saved_form.ssl_valid =
- form.origin.SchemeIsCryptographic() &&
- !client_->DidLastPageLoadEncounterSSLErrors();
provisionally_saved_form.preferred = true;
if (logger) {
logger->LogPasswordForm(Logger::STRING_PROVISIONALLY_SAVED_FORM,
@@ -530,11 +526,10 @@ void PasswordManager::CreatePendingLoginManagers(
if (logger)
logger->LogFormSignatures(Logger::STRING_ADDING_SIGNATURE, *iter);
- bool ssl_valid = iter->origin.SchemeIsCryptographic();
PasswordFormManager* manager = new PasswordFormManager(
this, client_,
(driver ? driver->AsWeakPtr() : base::WeakPtr<PasswordManagerDriver>()),
- *iter, ssl_valid,
+ *iter,
base::WrapUnique(new FormSaverImpl(client_->GetPasswordStore())));
pending_login_managers_.push_back(manager);

Powered by Google App Engine
This is Rietveld 408576698