Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

BUG=581865
TBR=cpu@chromium.org,jochen@chromium.org,raymes@chromium.org,rockot@chromium.org

Committed: https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486
Cr-Commit-Position: refs/heads/master@{#400126}

[dcheng, 2016-06-13 21:28:37]

dcheng@chromium.org changed reviewers:
+ danakj@chromium.org

[dcheng, 2016-06-13 21:28:38]

Note: I don't expect this to actually compile yet. I'm going to let the tryjobs
run overnight and fix up problems in the morning.

https://codereview.chromium.org/2065793002/diff/1/base/values.cc
File base/values.cc (right):

https://codereview.chromium.org/2065793002/diff/1/base/values.cc#newcode322
base/values.cc:322: return CreateWithCopiedBuffer(buffer_.get(),
size_).release();
I wanted to change this to be CreateDeepCopy() based but ran into the covariant
return issues. I'll figure out this cleanup in a followup.

[dcheng, 2016-06-14 20:17:59]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 20:18:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065793002/20001

[commit-bot: I haz the power, 2016-06-14 22:20:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 22:20:15]

Dry run: Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  ios-device-gn on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[dcheng, 2016-06-15 08:34:03]

+thakis, mind taking a look at this one?

https://codereview.chromium.org/2065793002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/wallpaper_api.cc (right):

https://codereview.chromium.org/2065793002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/wallpaper_api.cc:241:
SetResult(thumbnail_result->CreateDeepCopy());
Strictly speaking, not directly related, but may as well save myself some
trouble down the road.

https://codereview.chromium.org/2065793002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/audio_modem/audio_modem_api_unittest.cc
(right):

https://codereview.chromium.org/2065793002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/audio_modem/audio_modem_api_unittest.cc:74:
std::unique_ptr<ListValue> CreateList(std::unique_ptr<Value> single_elt) {
IIRC, we're passing something created by BinaryValue::CreateWithCopiedBuffer to
this helper. The corresponding changes are to make everything else still build.

https://codereview.chromium.org/2065793002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/pepper/pepper_socket_utils.cc (right):

https://codereview.chromium.org/2065793002/diff/20001/content/browser/rendere...
content/browser/renderer_host/pepper/pepper_socket_utils.cc:83:
base::MakeUnique<base::StringValue>(issuer.common_name));
We pass a created BinaryValue to SetField(), so I changed the signature of
SetField() and updated callers as needed.

https://codereview.chromium.org/2065793002/diff/20001/extensions/browser/api/...
File extensions/browser/api/web_request/upload_data_presenter_unittest.cc
(right):

https://codereview.chromium.org/2065793002/diff/20001/extensions/browser/api/...
extensions/browser/api/web_request/upload_data_presenter_unittest.cc:62:
ASSERT_TRUE(expected_c.get() != NULL);
These asserts don't really seem useful but meh. If you feel strongly, I can
remove these and inline the creation into the AppendKeyValuePair calls below.

[danakj, 2016-06-15 17:27:51]

LGTM

[dcheng, 2016-06-15 17:35:58]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-06-15 17:36:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065793002/20001

[commit-bot: I haz the power, 2016-06-15 17:46:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 17:46:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-06-15 21:26:17]

Description was changed from

==========
Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

BUG=581865
==========

to

==========
Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

BUG=581865
R=cpu@chromium.org,jochen@chromium.org,raymes@chromium.org,rockot@chromium.org
==========

[dcheng, 2016-06-15 21:26:17]

dcheng@chromium.org changed reviewers:
+ cpu@chromium.org, jochen@chromium.org, raymes@chromium.org,
rockot@chromium.org

[dcheng, 2016-06-15 21:26:31]

TBRing various owners

[dcheng, 2016-06-15 21:26:37]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-06-15 21:27:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065793002/20001

[commit-bot: I haz the power, 2016-06-15 21:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 21:38:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-06-16 08:01:25]

Description was changed from

==========
Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

BUG=581865
R=cpu@chromium.org,jochen@chromium.org,raymes@chromium.org,rockot@chromium.org
==========

to

==========
Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

BUG=581865
TBR=cpu@chromium.org,jochen@chromium.org,raymes@chromium.org,rockot@chromium.org
==========

[dcheng, 2016-06-16 08:01:34]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-06-16 08:02:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065793002/20001

[commit-bot: I haz the power, 2016-06-16 10:48:54]

Description was changed from

==========
Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

BUG=581865
TBR=cpu@chromium.org,jochen@chromium.org,raymes@chromium.org,rockot@chromium.org
==========

to

==========
Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

BUG=581865
TBR=cpu@chromium.org,jochen@chromium.org,raymes@chromium.org,rockot@chromium.org
==========

[commit-bot: I haz the power, 2016-06-16 10:48:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-16 10:50:19]

Description was changed from

==========
Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

BUG=581865
TBR=cpu@chromium.org,jochen@chromium.org,raymes@chromium.org,rockot@chromium.org
==========

to

==========
Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

BUG=581865
TBR=cpu@chromium.org,jochen@chromium.org,raymes@chromium.org,rockot@chromium.org

Committed: https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486
Cr-Commit-Position: refs/heads/master@{#400126}
==========

[commit-bot: I haz the power, 2016-06-16 10:50:21]

Patchset 2 (id:??) landed as
https://crrev.com/338b8829d4200d7ca84736e75e309311db3fd486
Cr-Commit-Position: refs/heads/master@{#400126}