Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android and CrOS Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc
diff --git a/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc b/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc
index 9f429bd66ef4d29768a0bff2d314248152a69ea3..45283e323e0636e18b0cd26dac9bb074460c97c7 100644
--- a/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc
+++ b/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc
@@ -4,6 +4,8 @@
#include "ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h"
+#include <utility>
+
#include "base/logging.h"
#include "ppapi/shared_impl/ppapi_globals.h"
#include "ppapi/shared_impl/var.h"
@@ -21,9 +23,9 @@ PPB_X509Certificate_Fields::PPB_X509Certificate_Fields(
void PPB_X509Certificate_Fields::SetField(
PP_X509Certificate_Private_Field field,
- base::Value* value) {
+ std::unique_ptr<base::Value> value) {
uint32_t index = static_cast<uint32_t>(field);
- bool success = values_.Set(index, value);
+ bool success = values_.Set(index, std::move(value));
DCHECK(success);
}

Powered by Google App Engine
This is Rietveld 408576698